Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Present captions on audio media #1047

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

DanOlson
Copy link

@DanOlson DanOlson commented Jun 5, 2024

Description of what you did:

Caption support was already there, but was only wired up for video. This adds the existing text track support for audio media as well.

Addresses part of #747

If approved, this is ready to be merged

Caption support was already there, but was only wired up for video.
This adds the existing text track support for audio media as well.
Copy link

codesandbox bot commented Jun 5, 2024

Review or Edit in CodeSandbox

Open the branch in Web EditorVS CodeInsiders

Open Preview

Copy link

vercel bot commented Jun 5, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
universalviewer ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 5, 2024 1:27am

Copy link

codesandbox-ci bot commented Jun 5, 2024

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

@demiankatz
Copy link
Contributor

@DanOlson, do you have any example manifests we can use to test/demonstrate this new functionality?

@DanOlson
Copy link
Author

DanOlson commented Jun 8, 2024

@demiankatz yes, here's one for an audio media item:

https://gist.githubusercontent.com/DanOlson/945c901a49ade5524bd1fb7fa920ceef/raw/e770069a5a77db5b20b0e7cc3326b1722e3b6f1f/interview-with-h-wyman-malmsten.json

and here's one for a video media item, for regression testing

https://gist.githubusercontent.com/DanOlson/e22318c3e6ea843784d5bc23d2f9b1ae/raw/c27df9dc0839ce0b071f80715928e1ed19da9064/assignment-for-tomorrow.json

The changes here assume the same structure for both audio and video manifests, where the canvas item's rendering property contains a Text object of format "text/vtt". No changes were made with regard to the expected structure of the manifest within MediaElementCenterPanel; I was just expanding on what existed previously for videos.

Please let me know if you need anything else. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: To be assessed
Development

Successfully merging this pull request may close these issues.

None yet

2 participants