Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump puppeteer from 1.9.0 to 22.7.0 #1013

Closed
wants to merge 1 commit into from

Conversation

dependabot[bot]
Copy link

@dependabot dependabot bot commented on behalf of github Apr 24, 2024

Bumps puppeteer from 1.9.0 to 22.7.0.

Release notes

Sourced from puppeteer's releases.

puppeteer-core: v22.7.0

22.7.0 (2024-04-23)

Features

Bug Fixes

puppeteer: v22.7.0

22.7.0 (2024-04-23)

Features

Dependencies

  • The following workspace dependencies were updated
    • dependencies
      • puppeteer-core bumped from 22.6.5 to 22.7.0

puppeteer-core: v22.6.5

22.6.5 (2024-04-15)

Bug Fixes

  • remove NetworkServiceInProcess2 set by default (#12261) (ff4f70f), closes #12257
  • use setImmediate to reduce flakiness when processing events (#12264) (73403b3)

Dependencies

  • The following workspace dependencies were updated
    • dependencies
      • @​puppeteer/browsers bumped from 2.2.1 to 2.2.2

puppeteer: v22.6.5

22.6.5 (2024-04-15)

Miscellaneous Chores

... (truncated)

Commits
Maintainer changes

This version was pushed to npm by google-wombot, a new releaser for puppeteer since your current version.


Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

@dependabot dependabot bot added dependencies Pull requests that update a dependency file javascript Pull requests that update Javascript code labels Apr 24, 2024
Copy link

codesandbox bot commented Apr 24, 2024

Review or Edit in CodeSandbox

Open the branch in Web EditorVS CodeInsiders

Open Preview

Copy link

vercel bot commented Apr 24, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
universalviewer ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 24, 2024 3:32pm

@demiankatz
Copy link
Contributor

@dependabot rebase

Bumps [puppeteer](https://github.com/puppeteer/puppeteer) from 1.9.0 to 22.7.0.
- [Release notes](https://github.com/puppeteer/puppeteer/releases)
- [Changelog](https://github.com/puppeteer/puppeteer/blob/main/release-please-config.json)
- [Commits](puppeteer/puppeteer@v1.9.0...puppeteer-v22.7.0)

---
updated-dependencies:
- dependency-name: puppeteer
  dependency-type: direct:development
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <[email protected]>
@dependabot dependabot bot force-pushed the dependabot/npm_and_yarn/dev/puppeteer-22.7.0 branch from a5f7d5b to d918b67 Compare April 24, 2024 15:30
Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Copy link
Contributor

@demiankatz demiankatz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I ran tests on this branch to see if it is possible to update puppeteer in isolation, but tests do not pass:

dkatz@dkatz-VirtualBox:~/universalviewer$ npm test

> [email protected] test
> jest

 FAIL  src/Utils.spec.ts
  ● Test suite failed to run

    TypeError: page.removeListener is not a function

      at PuppeteerEnvironment.teardown (node_modules/jest-environment-puppeteer/lib/PuppeteerEnvironment.js:134:12)
          at Generator.throw (<anonymous>)

 FAIL  __tests__/test.js
  ● Test suite failed to run

    TypeError: page.removeListener is not a function

      at PuppeteerEnvironment.teardown (node_modules/jest-environment-puppeteer/lib/PuppeteerEnvironment.js:134:12)
          at Generator.throw (<anonymous>)

 FAIL  __tests__/configuration_options.js
  ● Test suite failed to run

    TypeError: page.removeListener is not a function

      at PuppeteerEnvironment.teardown (node_modules/jest-environment-puppeteer/lib/PuppeteerEnvironment.js:134:12)
          at Generator.throw (<anonymous>)

 FAIL  src/content-handlers/iiif/PubSub.spec.ts
  ● Test suite failed to run

    TypeError: page.removeListener is not a function

      at PuppeteerEnvironment.teardown (node_modules/jest-environment-puppeteer/lib/PuppeteerEnvironment.js:134:12)
          at Generator.throw (<anonymous>)

 FAIL  src/content-handlers/iiif/modules/uv-shared-module/XYWHFragment.spec.ts
  ● Test suite failed to run

    TypeError: page.removeListener is not a function

      at PuppeteerEnvironment.teardown (node_modules/jest-environment-puppeteer/lib/PuppeteerEnvironment.js:134:12)
          at Generator.throw (<anonymous>)

Test Suites: 5 failed, 5 total
Tests:       0 total
Snapshots:   0 total
Time:        1.871s
Ran all test suites.

We should not merge this as-is; instead, we should figure out how to finish the work started in #984.

Copy link
Author

dependabot bot commented on behalf of github Apr 25, 2024

Superseded by #1015.

@dependabot dependabot bot closed this Apr 25, 2024
@dependabot dependabot bot deleted the dependabot/npm_and_yarn/dev/puppeteer-22.7.0 branch April 25, 2024 10:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file javascript Pull requests that update Javascript code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant