Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added the "timeout_wait" parameter to the CLI ("--timeout-wait="). #5812

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

max-krichenbauer
Copy link

Proposed change(s)

The timeout_wait parameter was not accessible through the CLI.
This is a problem when people need to debug their Unity scripts (temporarily pausing execution in the Unity Editor),
or when training is performed with human-in-the-loop,
as ml-agents will terminate the session after mere 60 seconds and throw a "UnityTimeOutException: The Unity environment took too long to respond."

Users should be able to set the timeout through the CLI with
--timeout-wait=<seconds>

Useful links (Github issues, JIRA tickets, ML-Agents forum threads etc.)

Types of change(s)

  • Bug fix
  • New feature
  • Code refactor
  • Breaking change
  • Documentation update
  • Other (please describe)

Checklist

  • Added tests that prove my fix is effective or that my feature works
  • Updated the changelog (if applicable)
  • Updated the documentation (if applicable)
  • Updated the migration guide (if applicable)

Other comments

maryamhonari and others added 2 commits September 22, 2022 12:25
@CLAassistant
Copy link

CLAassistant commented Nov 13, 2022

CLA assistant check
All committers have signed the CLA.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants