Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix duplicate edge #62

Merged
merged 3 commits into from
Mar 6, 2024
Merged

Conversation

dpgraham4401
Copy link
Member

Description

Fixes an issue where if a selection is made multiple times, an additional edge was added to the store with an identical ID to the edge created from the previous selection. The edges were removed from the store but the react UI was unable to update since the ID is used as the key in the react components (multiple objects with the same key problem).

Issue ticket number and link

closes #30

Checklist

  • I have added tests that prove my fix is effective or that my feature works
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings

@dpgraham4401 dpgraham4401 merged commit 91920a6 into USEPA:main Mar 6, 2024
8 checks passed
@dpgraham4401 dpgraham4401 deleted the fix-duplicate-edge branch March 6, 2024 14:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

duplicated bool node edges
1 participant