Fixing plt.show()
in plot_network
for network_animation
#405
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Solves issue #389 which describes problems using
wntr.graphics.network.network_animation
in Jupyter Notebooks by adding ashow_plot
parameter to thewntr.graphics.network.plot_network
function.show_plot
is set to 'True' by default onwntr.graphics.network.plot_network
, but changed toFalse
withinwntr.graphics.network.network_animation
. This makesnetwork_animation
work as intended.Tests and documentation
None; docstring for the
show_plot
parameter of thewntr.graphics.network.plot_network
function addedAcknowledgement
By contributing to this software project, I acknowledge that I have reviewed the software quality assurance guidelines and that my contributions are submitted under the Revised BSD License.