Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: build caching #508

Merged
merged 1 commit into from
May 29, 2024
Merged

feat: build caching #508

merged 1 commit into from
May 29, 2024

Conversation

Buckminsterfullerene02
Copy link
Member

@Buckminsterfullerene02 Buckminsterfullerene02 commented May 16, 2024

Description

Adds github action caching to the release actions. Currently it only works for xmake dependency downloads, so cuts down about 30% of the build time. Could not get it to work for incremental compiling though (tried adding --ccache=y to build target command, and adding build.cache policy in xmake.lua).

Type of change

  • New feature (non-breaking change which adds functionality)
  • Other... Github action

How Has This Been Tested?

Ran experimental action on branch a few times to check that the caching is being done properly.

Checklist

N/A

add more relevant build dirs

fix 3

fix 4

fix 5

fix 6

fix 7

fix 8

fix 9

fix 10

build caching xmake policy

typo

build caching doesn't work

add caching to release
@bitonality
Copy link
Contributor

(tried adding --ccache=y to build target command, and adding build.cache policy in `xmake.lua).

the ccache option should be part of configuration and not build command - i.e. xmake f -m "Game__Shipping__Win64" --ccache=y

Not sure if that's what you meant, let me know.

@bitonality
Copy link
Contributor

Also dumb question,

Is ccache installed on the runner?

@Buckminsterfullerene02
Copy link
Member Author

(tried adding --ccache=y to build target command, and adding build.cache policy in `xmake.lua).

the ccache option should be part of configuration and not build command - i.e. xmake f -m "Game__Shipping__Win64" --ccache=y

Not sure if that's what you meant, let me know.

Yeah, that's what I meant when I said "build target command".

@Buckminsterfullerene02
Copy link
Member Author

Also dumb question,

Is ccache installed on the runner?

I just assumed it was part of xmake, so I don't know...

@Buckminsterfullerene02
Copy link
Member Author

Turns out the build.cache policy really messes up proxy gen so I think it's better to just not touch that...

@bitonality
Copy link
Contributor

Turns out the build.cache policy really messes up proxy gen so I think it's better to just not touch that...

I'm open to investigating that once we've made some more headway in linux-land. This first pass dependency cache is already a big step in the right direction.

@narknon narknon merged commit 62ffdf4 into main May 29, 2024
@Buckminsterfullerene02 Buckminsterfullerene02 deleted the caching-action branch May 29, 2024 17:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants