-
-
Notifications
You must be signed in to change notification settings - Fork 429
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Fix 2 issues with experimentalWatchApi (#1159)
* Detect if files already updated by watchAPI * Only put files in cache if processed by loaders * Update comparison tests * Remove npm command for debugging tests * Remove package-lock.json * Update version & Changelog Co-authored-by: John Reilly <[email protected]>
- Loading branch information
1 parent
a77470f
commit 2f6cbe8
Showing
27 changed files
with
366 additions
and
44 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
9 changes: 5 additions & 4 deletions
9
...sWatchRefWithTwoFilesAlreadyBuilt_Composite_WatchApi/expectedOutput-3.9/patch2/output.txt
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,7 +1,8 @@ | ||
| Asset Size Chunks Chunk Names | ||
| app.d.ts 11 bytes [emitted] | ||
| bundle.js 4.85 KiB main [emitted] main | ||
| Asset Size Chunks Chunk Names | ||
| app.d.ts 11 bytes [emitted] | ||
| bundle.js 4.97 KiB main [emitted] main | ||
| tsconfig.tsbuildinfo 1.72 KiB [emitted] | ||
| Entrypoint main = bundle.js | ||
| [./app.ts] 131 bytes {main} [built] | ||
| [./app.ts] 215 bytes {main} [built] | ||
| [./lib/helper.ts] 138 bytes {main} | ||
| [./lib/index.ts] 224 bytes {main} |
63 changes: 63 additions & 0 deletions
63
...ithTwoFilesAlreadyBuilt_Composite_WatchApi/expectedOutput-3.9/patch2/tsconfig.tsbuildinfo
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,63 @@ | ||
| { | ||
| "program": { | ||
| "fileInfos": { | ||
| "../../node_modules/typescript/lib/lib.d.ts": { | ||
| "version": "-10496480823", | ||
| "signature": "-10496480823", | ||
| "affectsGlobalScope": false | ||
| }, | ||
| "../../node_modules/typescript/lib/lib.es5.d.ts": { | ||
| "version": "-218882352090", | ||
| "signature": "-218882352090", | ||
| "affectsGlobalScope": true | ||
| }, | ||
| "../../node_modules/typescript/lib/lib.dom.d.ts": { | ||
| "version": "300634082611", | ||
| "signature": "300634082611", | ||
| "affectsGlobalScope": true | ||
| }, | ||
| "../../node_modules/typescript/lib/lib.webworker.importscripts.d.ts": { | ||
| "version": "-24714112149", | ||
| "signature": "-24714112149", | ||
| "affectsGlobalScope": true | ||
| }, | ||
| "../../node_modules/typescript/lib/lib.scripthost.d.ts": { | ||
| "version": "204309182321", | ||
| "signature": "204309182321", | ||
| "affectsGlobalScope": true | ||
| }, | ||
| "./lib/index.d.ts": { | ||
| "version": "11215156582", | ||
| "signature": "11215156582", | ||
| "affectsGlobalScope": false | ||
| }, | ||
| "./lib/helper.d.ts": { | ||
| "version": "7897218607", | ||
| "signature": "7897218607", | ||
| "affectsGlobalScope": false | ||
| }, | ||
| "./app.ts": { | ||
| "version": "-12553192154", | ||
| "signature": "-3531856636", | ||
| "affectsGlobalScope": false | ||
| } | ||
| }, | ||
| "options": { | ||
| "types": [], | ||
| "composite": true, | ||
| "newLine": 1, | ||
| "configFilePath": "./tsconfig.json", | ||
| "skipLibCheck": true, | ||
| "suppressOutputPathCheck": true | ||
| }, | ||
| "referencedMap": { | ||
| "./app.ts": [ | ||
| "./lib/helper.d.ts", | ||
| "./lib/index.d.ts" | ||
| ] | ||
| }, | ||
| "exportedModulesMap": {}, | ||
| "semanticDiagnosticsPerFile": [] | ||
| }, | ||
| "version": "3.9.3" | ||
| } |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
9 changes: 5 additions & 4 deletions
9
...ectReferencesWatchRefWithTwoFiles_Composite_WatchApi/expectedOutput-3.9/patch1/output.txt
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,7 +1,8 @@ | ||
| Asset Size Chunks Chunk Names | ||
| app.d.ts 11 bytes [emitted] | ||
| bundle.js 4.83 KiB main [emitted] main | ||
| Asset Size Chunks Chunk Names | ||
| app.d.ts 11 bytes [emitted] | ||
| bundle.js 4.95 KiB main [emitted] main | ||
| tsconfig.tsbuildinfo 1.72 KiB [emitted] | ||
| Entrypoint main = bundle.js | ||
| [./app.ts] 131 bytes {main} [built] | ||
| [./app.ts] 215 bytes {main} [built] | ||
| [./lib/helper.ts] 138 bytes {main} | ||
| [./lib/index.ts] 211 bytes {main} |
63 changes: 63 additions & 0 deletions
63
...cesWatchRefWithTwoFiles_Composite_WatchApi/expectedOutput-3.9/patch1/tsconfig.tsbuildinfo
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,63 @@ | ||
| { | ||
| "program": { | ||
| "fileInfos": { | ||
| "../../node_modules/typescript/lib/lib.d.ts": { | ||
| "version": "-10496480823", | ||
| "signature": "-10496480823", | ||
| "affectsGlobalScope": false | ||
| }, | ||
| "../../node_modules/typescript/lib/lib.es5.d.ts": { | ||
| "version": "-218882352090", | ||
| "signature": "-218882352090", | ||
| "affectsGlobalScope": true | ||
| }, | ||
| "../../node_modules/typescript/lib/lib.dom.d.ts": { | ||
| "version": "300634082611", | ||
| "signature": "300634082611", | ||
| "affectsGlobalScope": true | ||
| }, | ||
| "../../node_modules/typescript/lib/lib.webworker.importscripts.d.ts": { | ||
| "version": "-24714112149", | ||
| "signature": "-24714112149", | ||
| "affectsGlobalScope": true | ||
| }, | ||
| "../../node_modules/typescript/lib/lib.scripthost.d.ts": { | ||
| "version": "204309182321", | ||
| "signature": "204309182321", | ||
| "affectsGlobalScope": true | ||
| }, | ||
| "./lib/index.d.ts": { | ||
| "version": "12503634626", | ||
| "signature": "12503634626", | ||
| "affectsGlobalScope": false | ||
| }, | ||
| "./lib/helper.d.ts": { | ||
| "version": "7897218607", | ||
| "signature": "7897218607", | ||
| "affectsGlobalScope": false | ||
| }, | ||
| "./app.ts": { | ||
| "version": "-12553192154", | ||
| "signature": "-3531856636", | ||
| "affectsGlobalScope": false | ||
| } | ||
| }, | ||
| "options": { | ||
| "types": [], | ||
| "composite": true, | ||
| "newLine": 1, | ||
| "configFilePath": "./tsconfig.json", | ||
| "skipLibCheck": true, | ||
| "suppressOutputPathCheck": true | ||
| }, | ||
| "referencedMap": { | ||
| "./app.ts": [ | ||
| "./lib/helper.d.ts", | ||
| "./lib/index.d.ts" | ||
| ] | ||
| }, | ||
| "exportedModulesMap": {}, | ||
| "semanticDiagnosticsPerFile": [] | ||
| }, | ||
| "version": "3.9.3" | ||
| } |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
9 changes: 5 additions & 4 deletions
9
...ison-tests/projectReferencesWatch_Composite_WatchApi/expectedOutput-3.9/patch1/output.txt
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,6 +1,7 @@ | ||
| Asset Size Chunks Chunk Names | ||
| app.d.ts 11 bytes [emitted] | ||
| bundle.js 4.33 KiB main [emitted] main | ||
| Asset Size Chunks Chunk Names | ||
| app.d.ts 11 bytes [emitted] | ||
| bundle.js 4.37 KiB main [emitted] main | ||
| tsconfig.tsbuildinfo 1.56 KiB [emitted] | ||
| Entrypoint main = bundle.js | ||
| [./app.ts] 131 bytes {main} [built] | ||
| [./app.ts] 169 bytes {main} [built] | ||
| [./lib/index.ts] 150 bytes {main} |
57 changes: 57 additions & 0 deletions
57
.../projectReferencesWatch_Composite_WatchApi/expectedOutput-3.9/patch1/tsconfig.tsbuildinfo
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,57 @@ | ||
| { | ||
| "program": { | ||
| "fileInfos": { | ||
| "../../node_modules/typescript/lib/lib.d.ts": { | ||
| "version": "-10496480823", | ||
| "signature": "-10496480823", | ||
| "affectsGlobalScope": false | ||
| }, | ||
| "../../node_modules/typescript/lib/lib.es5.d.ts": { | ||
| "version": "-218882352090", | ||
| "signature": "-218882352090", | ||
| "affectsGlobalScope": true | ||
| }, | ||
| "../../node_modules/typescript/lib/lib.dom.d.ts": { | ||
| "version": "300634082611", | ||
| "signature": "300634082611", | ||
| "affectsGlobalScope": true | ||
| }, | ||
| "../../node_modules/typescript/lib/lib.webworker.importscripts.d.ts": { | ||
| "version": "-24714112149", | ||
| "signature": "-24714112149", | ||
| "affectsGlobalScope": true | ||
| }, | ||
| "../../node_modules/typescript/lib/lib.scripthost.d.ts": { | ||
| "version": "204309182321", | ||
| "signature": "204309182321", | ||
| "affectsGlobalScope": true | ||
| }, | ||
| "./lib/index.d.ts": { | ||
| "version": "11215156582", | ||
| "signature": "11215156582", | ||
| "affectsGlobalScope": false | ||
| }, | ||
| "./app.ts": { | ||
| "version": "-16299197056", | ||
| "signature": "-3531856636", | ||
| "affectsGlobalScope": false | ||
| } | ||
| }, | ||
| "options": { | ||
| "types": [], | ||
| "composite": true, | ||
| "newLine": 1, | ||
| "configFilePath": "./tsconfig.json", | ||
| "skipLibCheck": true, | ||
| "suppressOutputPathCheck": true | ||
| }, | ||
| "referencedMap": { | ||
| "./app.ts": [ | ||
| "./lib/index.d.ts" | ||
| ] | ||
| }, | ||
| "exportedModulesMap": {}, | ||
| "semanticDiagnosticsPerFile": [] | ||
| }, | ||
| "version": "3.9.3" | ||
| } |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
16 changes: 11 additions & 5 deletions
16
...ison-tests/projectReferencesWatch_Composite_WatchApi/expectedOutput-3.9/patch4/output.txt
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,6 +1,12 @@ | ||
| Asset Size Chunks Chunk Names | ||
| app.d.ts 11 bytes [emitted] | ||
| bundle.js 4.37 KiB main [emitted] main | ||
| Asset Size Chunks Chunk Names | ||
| app.d.ts 11 bytes [emitted] | ||
| bundle.js 4.38 KiB main [emitted] main | ||
| tsconfig.tsbuildinfo 1.56 KiB [emitted] | ||
| Entrypoint main = bundle.js | ||
| [./app.ts] 169 bytes {main} [built] | ||
| [./lib/index.ts] 145 bytes {main} | ||
| [./app.ts] 186 bytes {main} [built] [1 error] | ||
| [./lib/index.ts] 145 bytes {main} | ||
|
|
||
| ERROR in app.ts | ||
| ./app.ts | ||
| [90m[tsl] [39m[1m[31mERROR[39m[22m[1m[31m in [39m[22m[1m[36mapp.ts(3,56)[39m[22m | ||
| [1m[31m TS2551: Property 'ffive' does not exist on type '{ one: number; two: number; three: number; four: number; five: number; }'. Did you mean 'five'?[39m[22m |
Oops, something went wrong.