Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

extend default config and fix scrolling #143

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

achimmihca
Copy link

@achimmihca achimmihca commented Jan 23, 2021

  • added missing (but available) parameters to default config
    • Stuff like DEAD_ZONE, SCROLL_DEAD_ZONE, TRIGGER_DEAD_ZONE and SCROLL_SPEED is already implemented but was not documented.
  • fix scrolling: must be an int
    • before, a float was passed to mouseEvent(...) which was causing issues.
  • apply getDelta(...) to tx and ty before any calculation is done
    • otherwise some calculations could have been done with wrong value already
  • pass magnitude to getMult instead of lengthsq
    • magnitude calculation can be simpler for scrolling because dimensions (X and Y) are handled independently (in this case magnitude is abs(deltaValue))
  • main.cpp : added (hard coded) build date to console output
    • motivation: I did not find any version information. This is needed to let users know which parameters are available and what is (not) working in their version.

- apply getDelta before any calculation is done
    -  otherwise some calculations could be done with wrong value
- pass magnitude to getMult instead of lengthsq
    - magnitude calculation can be simpler for scrolling because dimensions (X and Y) are handled independently (in this case magnitude is abs(deltaValue))
@KeneePatel
Copy link

Really think this should be merged. Also, if you know of any other program or tool which do a better job than this. Let me know!

@achimmihca
Copy link
Author

if you know of any other program or tool which do a better job than this. Let me know

I created a fork and a build that includes the changes of this PR: https://github.com/achimmihca/Gopher360/releases/tag/v1.0-achimmihca-fork

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants