sync wg changes #383
Merged
sync wg changes #383
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- perf: optimize Document.ValueToJSON() - perf: avoid unneccesary intermediate JSON object generation on input processing
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Co-authored-by: David Steinberger <[email protected]>
This fix improves drastically performance of enriching data in federated services. The inner for loop in jsonparser.ArrayEach is bottleneck if response to be enriched is large and has unique keys. The reason is size of responseMapping will grow to size of input, making computation n^2. In our case the fix reduced time from 20minutes to 16 seconds for response with hundred thousand objects. Co-authored-by: phob0s <[email protected]> Co-authored-by: Sergiy <[email protected]>
Co-authored-by: Sergiy <[email protected]>
If the response type of a field on a root type is changed, the alias checks would be bypassed by addCustomField. Co-authored-by: David Stutt <[email protected]>
Co-authored-by: David Stutt <[email protected]>
|
SonarCloud Quality Gate failed.
|
rhianeKobar
approved these changes
Aug 21, 2023
kofoworola
approved these changes
Aug 22, 2023
buraksezer
approved these changes
Aug 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR syncs following wg changes: