Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Comprehensive list of false positives #75

Open
wants to merge 8 commits into
base: master
Choose a base branch
from

Conversation

coggsflod
Copy link

Summary

Checklist

  • Tested and/or added tests to validate that the changes work as intended, if applicable.
  • [-] Updated documentation in README.md, if applicable.

Copy link
Owner

@TwiN TwiN left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I know I'm overreaching a bit, but that word made me think of encumber too.
Could you add encumber to the list of false positives too? 🙏

@coggsflod coggsflod changed the title Add 'incumbent' to false positive list Additional false positives Jan 29, 2024
@TwiN
Copy link
Owner

TwiN commented Feb 1, 2024

@coggsflod Let me know when you've completed the requested change 🙏

@coggsflod
Copy link
Author

@TwiN I decided to create a comprehensive false positive list based upon an english dictionary of non-profane words. I should have a revised PR with a complete list available in the next couple of days.

@coggsflod coggsflod changed the title Additional false positives Comprehensive list of false positives Feb 5, 2024
@coggsflod
Copy link
Author

@coggsflod Let me know when you've completed the requested change 🙏

Done!

@coggsflod coggsflod requested a review from TwiN February 7, 2024 12:49
@coggsflod
Copy link
Author

Hey @TwiN, I wanted to see if we're good to merge?

@TwiN
Copy link
Owner

TwiN commented May 29, 2024

Hey, sorry about the delay. I think you misunderstood how false positives work.

Adding "assault" would cover for assault* (assault, assaulting, assaults, assaulting, etc.), but instead, you explicitly added every word prefixed by assault.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants