feat(alerting): add timezone for maintenance #653
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #653 +/- ##
==========================================
+ Coverage 78.49% 78.53% +0.04%
==========================================
Files 58 58
Lines 4705 4714 +9
==========================================
+ Hits 3693 3702 +9
Misses 827 827
Partials 185 185 ☔ View full report in Codecov by Sentry. |
| @@ -12,6 +12,7 @@ var ( | |||
| errInvalidMaintenanceStartFormat = errors.New("invalid maintenance start format: must be hh:mm, between 00:00 and 23:59 inclusively (e.g. 23:00)") | |||
| errInvalidMaintenanceDuration = errors.New("invalid maintenance duration: must be bigger than 0 (e.g. 30m)") | |||
| errInvalidDayName = fmt.Errorf("invalid value specified for 'on'. supported values are %s", longDayNames) | |||
| errInvalidTimezone = errors.New("invalid timezone specified or format not supported. Use IANA timezone format (e.g. America/Sao_Paulo)") | |||
There was a problem hiding this comment.
Can you update the README to include this information about the timezone format to use?
There was a problem hiding this comment.
Can you update the README to include this information about the timezone format to use?
Certainly, I've done it, but it seems a little awkward when I look at the line in the table with the parameter maintenance.timezone. I am referring to the length of the line. Is it okay, or should I change it?"
|
@TwiN Can you review this PR? I've made some changes that you are asked for |
Summary
Add a "Timezone" field to the configuration in the maintenance zone to specify the timezone for the maintenance window. Also, include tests for various timezones and cases.
Fixes #327
Checklist
README.md, if applicable.