feat: update to macOS 14 to use the new onChange with { oldValue, newValue in ...
#3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…newValue in ...`
mesqueeb
changed the title
onChange with `{ oldValue, …onChange with { oldValue, newValue in ...
|
Thanks for the pull request. Unfortunately I see some issues. Regarding the used API and minimum version upgrade I would like to avoid that. Instead I have a draft pull request #1 where I added them as separate variants to keep compatibility with older versions. I can finish it for next library update. As for the change with new optional Task parameter it looks ok, but I would like to first confirm your use case (see my comment in issue). Once we do that we can finish the pull request. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #2