Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refreshed & Enhanced UI #674

Open
wants to merge 5 commits into
base: branch-0.4.2
Choose a base branch
from

Conversation

sunil32150
Copy link

#16 # What is this PR for?
In this version you will find a new fresh ui/look and feel, enhanced side bar, multiple theme, new login page, Dashboard page enhanced, Widget function enhanced, every page is now data-grid functioned , add edit delete is much easier and have enhanced look. Role and user module is enhanced and shown in different pages.

What type of PR is it?

Improvement & eature

What is the Github issue?

How should this be tested?

Just Build and run

Screenshots (if appropriate)

image
image
image

image

And other places have also been changed to list view.

In this version you will find a new fresh ui/look and feel, enhanced side bar, multiple theme, new login page, Dashboard page enhanced, Widget function enhanced, every page is now data-grid functioned , add edit delete is much easier and have enhanced look. Role and user module is enhanced and shown in different pages.
Changes in dependecies
@yzhang921
Copy link
Collaborator

yzhang921 commented Jul 14, 2019

Great job, we need to take some time to do detail code review. But there are some obvious problems I can point out.
1 it would be better to extract the duplicated code of pagination.
2 Please replace all the tab with 4 white spaces
3 Looks like you have missing files to commit

http://localhost:8025/imgs/syncGrid.png 404
http://localhost:8025/imgs/syncGrid-active.png 404
http://localhost:8025/org/cboard/view/config/chart/grid.html 404
http://localhost:8025/org/cboard/view/config/chart/options/grid.html 404

4 Change ES6 style arrow function to ES5 normal function at the following files, that may cause some low version chrome can't compatible:

  • userAdminCtrl.js
  • dashboardViewCtrl.js
  • widgetCtrl.js

5 I don't think it's a good idea to remove the jstree resource style of widget/dataset
6 and also user, role and resource page split is not convenient to manged in separate page.

@yzhang921
Copy link
Collaborator

I will help to forward this pr to more user group to involve in voting, thanks!

1 it would be better to extract the duplicated code of pagination.
2 Please replace all the tab with 4 white spaces
3 Looks like you have missing files to commit

http://localhost:8025/imgs/syncGrid.png 404
http://localhost:8025/imgs/syncGrid-active.png 404
http://localhost:8025/org/cboard/view/config/chart/grid.html 404
http://localhost:8025/org/cboard/view/config/chart/options/grid.html 404
4 Change ES6 style arrow function to ES5 normal function at the following files, that may cause some low version chrome can't compatible:

userAdminCtrl.js
dashboardViewCtrl.js
widgetCtrl.js
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants