Added cache-control: private headers for all link redirects #20117
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ref https://linear.app/tryghost/issue/ENG-883/add-cache-control-private-headers-to-the-link-redirects - Link redirects shouldn't be cached because we record which member clicked the link on the redirect - This PR adds cache-control: private headers to all link redirects to prevent them from being cached
cmraible
force-pushed
the
chris-eng-883-add-cache-control-private-headers-to-the-link-redirects
branch
from
00674f4
to
198b88e
Compare
|
PR ready to go, just waiting to merge because I have a larger change in the same area going in soon and I don't want to skew my validation results by making two changes at the same time. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ref https://linear.app/tryghost/issue/ENG-883/add-cache-control-private-headers-to-the-link-redirects
cache-control: privateheaders to all link redirects to prevent them from being cached