Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix potential GitHub Actions smells #20096

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

ceddy4395
Copy link

Hey! 馃檪
I want to contribute the following changes to your workflow:

  • Avoid executing scheduled workflows on forks
  • Prevent running issue/PR actions on forks
  • Use names for run steps
  • Define permissions for workflows with external actions
  • Steps should only perform a single command
  • Use commit hash instead of tags for action versions
  • Avoid jobs without timeouts
  • Use fixed version for runs-on argument

(These changes are part of a research Study at TU Delft looking at GitHub Action Smells. Find out more)

Got some code for us? Awesome 馃帄!

Please include a description of your change & check your PR against this list, thanks!

  • There's a clear use-case for this code change, explained below
  • Commit message has a short title & references relevant issues
  • The build will pass (run yarn test:all and yarn lint)

We appreciate your contribution!

- Avoid executing  scheduled workflows on forks
- Prevent running issue/PR actions on forks
- Use names for run steps
- Define permissions for workflows with external actions
- Steps should only perform a single command
- Use commit hash instead of tags for action versions
- Avoid jobs without timeouts
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant