馃悰 Fixed redundant member data loading for static assets #20031
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ronaldlangeveld
changed the title
mike182uk
reviewed
May 7, 2024
ghost/core/core/frontend/web/middleware/members-session-handler.js
Outdated
Show resolved
Hide resolved
ronaldlangeveld
changed the title
ronaldlangeveld
changed the title
ref CFR-21 - Spike WIP - Added testing to spy that will determine when the loadMemberSession is executed on a request. - Added known routes where we don't need this middleware from executing. - The method currently used is to reorganise the pattern in which the middleware loads, ensuring we only execute `loadMemberSession` where needed, after the the paths that don't require it.
mike182uk
force-pushed
the
spike-remove-members-middleware
branch
from
c896e68
to
9a8d604
Compare
mike182uk
force-pushed
the
spike-remove-members-middleware
branch
from
9a8d604
to
8bc012b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
refs CFR-21
Reorganised middleware execution so that member data is not redundantly loaded for static assets or the sitemap