Skip to content

Commit

Permalink
fix(GBM): missing functionality of use_reduction_sum (#68)
Browse files Browse the repository at this point in the history
* Update gradient_boosting.py

* Update CHANGELOG.rst
  • Loading branch information
xuyxu authored Apr 26, 2021
1 parent 7f16b8f commit c4f6fdf
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 0 deletions.
1 change: 1 addition & 0 deletions CHANGELOG.rst
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@ Changelog
Ver 0.1.*
---------

* |Fix| Fix missing functionality of ``use_reduction_sum`` for :meth:`fit` of Gradient Boosting | `@xuyxu <https://github.com/xuyxu>`__
* |Enhancement| Relax :mod:`tensorboard` as a soft dependency | `@xuyxu <https://github.com/xuyxu>`__
* |Enhancement| |API| Simplify the training workflow of :class:`FastGeometricClassifier` and :class:`FastGeometricRegressor` | `@xuyxu <https://github.com/xuyxu>`__
* |Feature| |API| Support TensorBoard logging in :meth:`set_logger` | `@zzzzwj <https://github.com/zzzzwj>`__
Expand Down
2 changes: 2 additions & 0 deletions torchensemble/gradient_boosting.py
Original file line number Diff line number Diff line change
Expand Up @@ -427,6 +427,7 @@ def fit(
super().fit(
train_loader=train_loader,
epochs=epochs,
use_reduction_sum=use_reduction_sum,
log_interval=log_interval,
test_loader=test_loader,
early_stopping_rounds=early_stopping_rounds,
Expand Down Expand Up @@ -538,6 +539,7 @@ def fit(
super().fit(
train_loader=train_loader,
epochs=epochs,
use_reduction_sum=use_reduction_sum,
log_interval=log_interval,
test_loader=test_loader,
early_stopping_rounds=early_stopping_rounds,
Expand Down

0 comments on commit c4f6fdf

Please sign in to comment.