fix: The logger drops frame with the "Success" status. #2765
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nickolay168
changed the title
nickolay168
force-pushed
the
nick168/add_more_logging
branch
from
5c24d14 to
9dbb6c4
Compare
iphydf
force-pushed
the
nick168/add_more_logging
branch
from
7081992 to
c15eb78
Compare
github-actions
bot
added
the
bug
iphydf
force-pushed
the
nick168/add_more_logging
branch
from
c15eb78 to
e32ac00
Compare
iphydf
approved these changes
Jan 14, 2025
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #2765 +/- ##
==========================================
- Coverage 72.63% 72.55% -0.08%
==========================================
Files 150 150
Lines 30757 30779 +22
==========================================
- Hits 22339 22333 -6
- Misses 8418 8446 +28 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: When the frame is dropped during the video call non informative message is logged:
[04:15:03.304 UTC] rtp.c:842 : Warning: RTP send failed (len: 1373)! net error: SuccessSolution: In this PR I have added logging of custom toxcore error in addition to network error, which is not necessary contains the error code.
Please see corresponding issue for more info.
This change is