fix: Avoid memcpy-ing structs into onion ping id data.
#2687
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2687 +/- ##
==========================================
+ Coverage 72.89% 73.14% +0.24%
==========================================
Files 149 149
Lines 30570 30565 -5
==========================================
+ Hits 22285 22357 +72
+ Misses 8285 8208 -77 ☔ View full report in Codecov by Sentry. |
iphydf
force-pushed
the
onion-ping-id
branch
from
68302cd to
d974afe
Compare
iphydf
force-pushed
the
onion-ping-id
branch
from
d974afe to
82545f5
Compare
github-actions
bot
added
the
bug
iphydf
force-pushed
the
onion-ping-id
branch
from
82545f5 to
0f72a4c
Compare
Although it is only ever read back on the machine it originated from, it's bad practice and we should not make our protocol have system-specific undefined padding bytes in it.
Green-Sky
reviewed
Dec 17, 2024
| memcpy(ping_id_data, packet_public_key, CRYPTO_PUBLIC_KEY_SIZE); | ||
| memcpy(ping_id_data + CRYPTO_PUBLIC_KEY_SIZE, source, sizeof(*source)); | ||
| const int packed_len = pack_ip_port(onion_a->log, &ping_id_data[CRYPTO_PUBLIC_KEY_SIZE], SIZE_IPPORT, source); | ||
| memzero(&ping_id_data[CRYPTO_PUBLIC_KEY_SIZE + packed_len], SIZE_IPPORT - packed_len); |
There was a problem hiding this comment.
assert packed_len <= SIZE_IPPORT ?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Although it is only ever read back on the machine it originated from, it's bad practice and we should not make our protocol have system-specific undefined padding bytes in it.
Found by TokTok/hs-tokstyle#252
This change is