This repository has been archived by the owner on Jun 10, 2021. It is now read-only.
key mod #27
Merged
key mod #27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Artemis-chan
added
type: enhancement
|
wonder if there's a way to use custom graphics as mod icons |
Thesola10
suggested changes
Apr 8, 2021
| public class DivaModKey3 : DivaKeyMod | ||
| { | ||
| public override int KeyCount => 3; | ||
| public override string Name => "3 Button"; |
There was a problem hiding this comment.
should be "Three Button" for consistency
Actually make Button plural on all ModKey as well?
|
No functional problems upon testing tho |
It seems like they are using customs fonts for the custom mod graphics (source). |
|
Doesn't that mean we can introduce our own font (it's some compiled PNG table) and use that for mod icons? |
|
i have looked into it, (this is how the framework loads) |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes part 1 of #4, backported from osu mania as suggested by @Thesola10