Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update from legacy doc #27972

Merged
merged 2 commits into from
May 20, 2024
Merged

Update from legacy doc #27972

merged 2 commits into from
May 20, 2024

Conversation

asdacosta
Copy link
Contributor

Because

Replace legacy documentation link which is no longer updated to the current one.

This PR

  • Change legacy documentation to the current one.

Issue

Closes #XXXXX

Additional Information

Pull Request Requirements

  • I have thoroughly read and understand The Odin Project curriculum contributing guide
  • The title of this PR follows the location of change: brief description of change format, e.g. Intro to HTML and CSS lesson: Fix link text
  • The Because section summarizes the reason for this PR
  • The This PR section has a bullet point list describing the changes in this PR
  • If this PR addresses an open issue, it is linked in the Issue section
  • If any lesson files are included in this PR, they have been previewed with the Markdown preview tool to ensure it is formatted correctly
  • If any lesson files are included in this PR, they follow the Layout Style Guide

Replace legacy doc which is no longer updated to the current doc
@github-actions github-actions bot added the Content: React Involves the React course label May 14, 2024
@CouchofTomato
Copy link
Member

There seems to be a linting failure. Would you mind addressing that in this PR?

@asdacosta
Copy link
Contributor Author

There seems to be a linting failure. Would you mind addressing that in this PR?

I can't change the js to javascript since it's a link and doing that will distort it.

@CouchofTomato
Copy link
Member

There seems to be a linting failure. Would you mind addressing that in this PR?

I can't change the js to javascript since it's a link and doing that will distort it.

A link?

@asdacosta
Copy link
Contributor Author

There seems to be a linting failure. Would you mind addressing that in this PR?

I can't change the js to javascript since it's a link and doing that will distort it.

A link?

Yes. I think it's from this 'https://reactjs'

@CouchofTomato
Copy link
Member

This doesn't look like a link to me in the markdown. It might be a github thing you're seeing.

@asdacosta
Copy link
Contributor Author

This doesn't look like a link to me in the markdown. It might be a github thing you're seeing.

I did not copy the full link, I was trying to highlight where I think the problem is from. The link does contain 'js' which from the error, it says it is supposed to be 'javascript' rather.

@CouchofTomato
Copy link
Member

The markdown itself doesn't look like a link. You just need to change js to javascript

image

@asdacosta
Copy link
Contributor Author

The markdown itself doesn't look like a link. You just need to change js to javascript

image

Ok
Should I close the PR and create another one with the update?

@CouchofTomato
Copy link
Member

You should just be able to make the change and push up.

Use full name for js language in fenced code blocks to correct linting failure.
@asdacosta
Copy link
Contributor Author

You should just be able to make the change and push up.

Done.

@CouchofTomato CouchofTomato merged commit 8936ea5 into TheOdinProject:main May 20, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Content: React Involves the React course
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants