Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Debugging nodejs.fix #27893

Open
wants to merge 11 commits into
base: main
Choose a base branch
from

Conversation

MarkoMTP
Copy link

Because

This PR

Issue

Closes #XXXXX

Additional Information

Pull Request Requirements

  • I have thoroughly read and understand The Odin Project curriculum contributing guide
  • The title of this PR follows the location of change: brief description of change format, e.g. Intro to HTML and CSS lesson: Fix link text
  • The Because section summarizes the reason for this PR
  • The This PR section has a bullet point list describing the changes in this PR
  • If this PR addresses an open issue, it is linked in the Issue section
  • If any lesson files are included in this PR, they have been previewed with the Markdown preview tool to ensure it is formatted correctly
  • If any lesson files are included in this PR, they follow the Layout Style Guide

@github-actions github-actions bot added Content: NodeJS Involves the NodeJS course Content: Foundations Involves the Foundations content labels Apr 29, 2024
@MaoShizhong MaoShizhong mentioned this pull request Apr 29, 2024
7 tasks
Copy link
Contributor

@MaoShizhong MaoShizhong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @MarkoMTP. Just a couple of changes required which are detailed below.
For future PRs, please could you make sure you fill out all required parts of the PR form.

@@ -18,7 +18,7 @@ When asking a question, it is essential to provide your code, error message, ter

If your question does not provide any code or other relevant information, it will be difficult for others to help you. In order to fully understand your question, there will be a lot of unnecessary back and forth conversation. This can be discouraging for you because any answers with incomplete information will not solve your problem. This process can be frustrating for those helping because the meaning of your original question changes as you add more context to it. If you truly want to ask a conceptual question, you should indicate this as part of your question.

#### Ask about the problem at hand, not the solution itself
#### Ask about the problem at hand, not the solution itself, this will be edited for practice
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
#### Ask about the problem at hand, not the solution itself, this will be edited for practice
#### Ask about the problem at hand, not the solution itself

Ideally, please make practice changes and PRs in your own test repos, otherwise you risk accidentally including unwanted changes in your PR.

@@ -12,9 +13,10 @@ This section contains a general overview of topics that you will learn in this l

<div class="lesson-content__panel" markdown="1">

- Watch [this video tutorial about Node.js debugging in VS Code](https://www.youtube.com/watch?v=2oFKNL7vYV8&ab_channel=VisualStudioCode) to see the process in action.
- Watch [video tutorial about Node.js debugging in VS Code](https://www.youtube.com/watch?v=2oFKNL7vYV8&ab_channel=VisualStudioCode) to see the process in action.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- Watch [video tutorial about Node.js debugging in VS Code](https://www.youtube.com/watch?v=2oFKNL7vYV8&ab_channel=VisualStudioCode) to see the process in action.
- Watch this [video tutorial about Node.js debugging in VS Code](https://www.youtube.com/watch?v=2oFKNL7vYV8&ab_channel=VisualStudioCode) to see the process in action.

Still need this, just outside of the link text

Comment on lines +18 to +19
Read this article for a tutorial on [how to debug Node with Chrome](https://web.archive.org/web/20230923074524/https://www.section.io/engineering-education/debug-node-devtools/).
NOTE: You can ignore anything that refers to debugging remote apps- you'll be debugging local apps.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Read this article for a tutorial on [how to debug Node with Chrome](https://web.archive.org/web/20230923074524/https://www.section.io/engineering-education/debug-node-devtools/).
NOTE: You can ignore anything that refers to debugging remote apps- you'll be debugging local apps.
- Read this article for a tutorial on [how to debug Node with Chrome](https://web.archive.org/web/20230923074524/https://www.section.io/engineering-education/debug-node-devtools/). NOTE: You can ignore anything that refers to debugging remote apps- you'll be debugging local apps.

Need to keep these on the same line as well as make sure we still have the - to mark it as an item in a ul. Also popping a blank line after it since it'll fix one linting error - might as well while we're at it.

Comment on lines +75 to +76
1. [MDN's "The Server Side"](https://developer.mozilla.org/en-US/docs/Learn/Server-side/First_steps) is a great source
for the background knowledge you need. Read through at least the first two articles posted under the 'Guides' section: Introduction to the server side and Client-Server Overview. The other two are interesting and worth reviewing, but less relevant to our immediate concerns.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
1. [MDN's "The Server Side"](https://developer.mozilla.org/en-US/docs/Learn/Server-side/First_steps) is a great source
for the background knowledge you need. Read through at least the first two articles posted under the 'Guides' section: Introduction to the server side and Client-Server Overview. The other two are interesting and worth reviewing, but less relevant to our immediate concerns.
1. [MDN's "The Server Side"](https://developer.mozilla.org/en-US/docs/Learn/Server-side/First_steps) is a great source for the background knowledge you need. Read through at least the first two articles posted under the 'Guides' section: Introduction to the server side and Client-Server Overview. The other two are interesting and worth reviewing, but less relevant to our immediate concerns.

1. [MDN's "The Server Side"](https://developer.mozilla.org/en-US/docs/Learn/Server-side/First_steps) is a great source
for the background knowledge you need. Read through at least the first two articles posted under the 'Guides' section: Introduction to the server side and Client-Server Overview. The other two are interesting and worth reviewing, but less relevant to our immediate concerns.
2. To gain a little more insight into the nature of Node, and to unpack the rest of the above definition, read ["What exactly is Node.js?"](https://medium.freecodecamp.org/what-exactly-is-node-js-ae36e97449f5)
3. What is the Node Event Loop?Check out this long, but _really_ fantastic [video on what the Node Event Loop is](https://www.youtube.com/watch?v=8aGhZQkoFbQ). Don’t skip it!
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
3. What is the Node Event Loop?Check out this long, but _really_ fantastic [video on what the Node Event Loop is](https://www.youtube.com/watch?v=8aGhZQkoFbQ). Don’t skip it!
3. What is the Node Event Loop? Check out this long, but *really* fantastic [video on what the Node Event Loop is](https://www.youtube.com/watch?v=8aGhZQkoFbQ). Don’t skip it!

for the background knowledge you need. Read through at least the first two articles posted under the 'Guides' section: Introduction to the server side and Client-Server Overview. The other two are interesting and worth reviewing, but less relevant to our immediate concerns.
2. To gain a little more insight into the nature of Node, and to unpack the rest of the above definition, read ["What exactly is Node.js?"](https://medium.freecodecamp.org/what-exactly-is-node-js-ae36e97449f5)
3. What is the Node Event Loop?Check out this long, but _really_ fantastic [video on what the Node Event Loop is](https://www.youtube.com/watch?v=8aGhZQkoFbQ). Don’t skip it!

4. Take a few minutes to go through the "Getting Started" section of the new official [Node.js website](https://nodejs.org/en/learn/getting-started/introduction-to-nodejs). Read up until, but not including, the TypeScript module.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
4. Take a few minutes to go through the "Getting Started" section of the new official [Node.js website](https://nodejs.org/en/learn/getting-started/introduction-to-nodejs). Read up until, but not including, the TypeScript module.
4. Take a few minutes to go through the ["Getting Started" section of the new official Node.js website](https://nodejs.org/en/learn/getting-started/introduction-to-nodejs). Read up until, but not including, the TypeScript module.

This wasn't in the spreadsheet because I missed it. Just noticed it can be improved so if you wouldn't mind fixing this up too, that'd be wonderful.

@MaoShizhong
Copy link
Contributor

@MarkoMTP just checking in if you've seen the above

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Content: Foundations Involves the Foundations content Content: NodeJS Involves the NodeJS course
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants