Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sorting Algorithms #22

Draft
wants to merge 18 commits into
base: main
Choose a base branch
from
Draft

Conversation

dlesnoff
Copy link
Collaborator

@dlesnoff dlesnoff commented Jun 2, 2023

Add multiple sorting algorithms: insertion sort, selection sort, bubble sort, merge sort
with a file for some common tests.

I hesitate to add additional tests to illustrate the stability property of some sorts or to add the possibility to change the comparison function.
I want to keep thing simple to be as much pedagogical as possible.

DIRECTORY.md Show resolved Hide resolved
@dlesnoff dlesnoff marked this pull request as draft June 2, 2023 16:29
@Panquesito7 Panquesito7 added the enhancement New feature or request label Jun 2, 2023
@dlesnoff dlesnoff mentioned this pull request Dec 3, 2023
@ZoomRmc
Copy link
Contributor

ZoomRmc commented Nov 11, 2024

Took a glance over. Looks great, I like the code/comment ratio (I'd spray TODO marks around those add description lines).

I think the testing scaffolding should live somewhere separately. Do you think it would be beneficial to start collecting the testing utils we can recommend to new contributors?

Also, in general, I don't like unseeded random in tests. No harm here, but they should be reproducible.

Re if verbose that you don't actually use, perhaps the checks can be swapped to when defined(debug)?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants