Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: added SubsetSum algo and its tests in Recursive Algos #1734

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

HRIDYANSHU054
Copy link
Contributor

@HRIDYANSHU054 HRIDYANSHU054 commented Oct 17, 2024

Open in Gitpod know more

Describe your change:

  • Add an algorithm?
    Added SubsetSum algorithm and its tests in Recursive Alogrithms.
/**
 * @function subsetSum
 * @description This function recursively calculates the count of subsets whose sum equals the given target sum.
 * @param {number[]} arr - The input array of numbers.
 * @param {number} sum - The target sum we want to find in the subsets.
 * @param {number} ind - The current index.
 * @return {number} The count of subsets whose sum equals the target sum.
 *
 */

export function subsetSum(arr, sum, ind = 0) {
  //input validation only in the inital call
  if (
    ind === 0 &&
    (!Array.isArray(arr) || !arr.every((elem) => typeof elem === 'number'))
  ) {
    throw new TypeError('arr should be an array of numbers')
  }

  if (ind === 0 && typeof sum !== 'number') {
    throw new TypeError('sum should be a number')
  }

  if (ind === arr.length) {
    return sum === 0 ? 1 : 0
  }

  return subsetSum(arr, sum, ind + 1) + subsetSum(arr, sum - arr[ind], ind + 1)
}

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new JavaScript files are placed inside an existing directory.
  • All filenames should use the UpperCamelCase (PascalCase) style. There should be no spaces in filenames.
    Example:UserProfile.js is allowed but userprofile.js,Userprofile.js,user-Profile.js,userProfile.js are not
  • All new algorithms have a URL in their comments that points to Wikipedia or another similar explanation.
  • If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.

@codecov-commenter
Copy link

codecov-commenter commented Oct 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.81%. Comparing base (ff314a2) to head (5426682).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1734      +/-   ##
==========================================
+ Coverage   84.76%   84.81%   +0.04%     
==========================================
  Files         378      379       +1     
  Lines       19742    19799      +57     
  Branches     2955     2967      +12     
==========================================
+ Hits        16735    16792      +57     
  Misses       3007     3007              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@HRIDYANSHU054
Copy link
Contributor Author

@appgurueu kindly see if this should be added to recursive algorithms

@HRIDYANSHU054
Copy link
Contributor Author

@appgurueu @raklaptudirm
Can you check this and let me know if this can be added to Recursive Algorithms?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants