Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add SpiralMatrix Algo Solution #1717

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

rajprogrammerbd
Copy link

Open in Gitpod know more

Describe your change:

  • [ y] Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?

Checklist:

  • [y ] I have read CONTRIBUTING.md.
  • [ y] This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new JavaScript files are placed inside an existing directory.
  • All filenames should use the UpperCamelCase (PascalCase) style. There should be no spaces in filenames.
    Example:UserProfile.js is allowed but userprofile.js,Userprofile.js,user-Profile.js,userProfile.js are not
  • All new algorithms have a URL in their comments that points to Wikipedia or another similar explanation.
  • If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.

@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 98.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 84.69%. Comparing base (18da83a) to head (bf135b3).

Files with missing lines Patch % Lines
Dynamic-Programming/spiralMatrix.js 98.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1717      +/-   ##
==========================================
+ Coverage   84.65%   84.69%   +0.03%     
==========================================
  Files         378      379       +1     
  Lines       19744    19794      +50     
  Branches     2951     2965      +14     
==========================================
+ Hits        16715    16764      +49     
- Misses       3029     3030       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@appgurueu
Copy link
Collaborator

I would consider this more of a solution to a programming problem than something which is algorithmically very involved so I'm afraid I'm not sure this is in scope. @raklaptudirm what do you think?

@rajprogrammerbd
Copy link
Author

@appgurueu This solution is an approach to solving similar spiral matrix-related problems. Does that make sense? If not, could you please suggest any changes?

@appgurueu
Copy link
Collaborator

This solution is an approach to solving similar spiral matrix-related problems.

I'm aware of what this code implements. I'm just not convinced it fits here: I think it's more of a "programming" problem than an "algorithm" problem, if that makes sense.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants