Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added surface area calculation for pyramid #6062

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Added surface area calculation for pyramid #6062

wants to merge 1 commit into from

Conversation

GitHerDone17
Copy link

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized it.
  • All filenames are in PascalCase.
  • All functions and variable names follow Java naming conventions.
  • All new algorithms have a URL in their comments that points to Wikipedia or other similar explanations.
  • All new code is formatted with clang-format -i --style=file path/to/your/file.java

GitHerDone17
GitHerDone17 commented Oct 30, 2024
View reviewed changes
src/main/java/com/thealgorithms/maths/Area.java
@@ -192,4 +192,17 @@ public static double surfaceAreaCone(final double radius, final double height) {
}
return Math.PI * radius * (radius + Math.pow(height * height + radius * radius, 0.5));
}

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added as part of the lab

@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 0% with 7 lines in your changes missing coverage. Please review.

Project coverage is 73.39%. Comparing base (03bb8ee) to head (2750ba1).

Files with missing lines Patch % Lines
src/main/java/com/thealgorithms/maths/Area.java 0.00% 7 Missing ⚠️
Additional details and impacted files 
@@             Coverage Diff              @@
##             master    #6062      +/-   ##
============================================
- Coverage     73.42%   73.39%   -0.03%     
  Complexity     5078     5078              
============================================
  Files           656      656              
  Lines         17617    17624       +7     
  Branches       3394     3395       +1     
============================================
  Hits          12936    12936              
- Misses         4180     4187       +7     
  Partials        501      501

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

GitHerDone17
GitHerDone17 commented Oct 30, 2024
View reviewed changes
Copy link
Author

@GitHerDone17 GitHerDone17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed

siriak
siriak requested changes Oct 30, 2024
View reviewed changes
Copy link
Member

@siriak siriak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add JUnit tests and fix PR checks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@siriak siriak siriak requested changes

@yanglbme yanglbme Awaiting requested review from yanglbme yanglbme is a code owner

@vil02 vil02 Awaiting requested review from vil02 vil02 is a code owner

@BamaCharanChhandogi BamaCharanChhandogi Awaiting requested review from BamaCharanChhandogi BamaCharanChhandogi is a code owner

@alxkm alxkm Awaiting requested review from alxkm alxkm is a code owner

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@GitHerDone17 @codecov-commenter @siriak