Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create MetaBinarySearch.java #5955

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Conversation

Fenirok
Copy link

@Fenirok Fenirok commented Oct 23, 2024

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized it.
  • All filenames are in PascalCase.
  • All functions and variable names follow Java naming conventions.
  • All new algorithms have a URL in their comments that points to Wikipedia or other similar explanations.
  • All new code is formatted with clang-format -i --style=file path/to/your/file.java

@codecov-commenter
Copy link

codecov-commenter commented Oct 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 67.99%. Comparing base (5246f63) to head (bcafa90).

Additional details and impacted files
@@             Coverage Diff              @@
##             master    #5955      +/-   ##
============================================
+ Coverage     67.98%   67.99%   +0.01%     
- Complexity     4586     4587       +1     
============================================
  Files           620      620              
  Lines         17116    17116              
  Branches       3305     3305              
============================================
+ Hits          11636    11638       +2     
+ Misses         5035     5034       -1     
+ Partials        445      444       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@siriak siriak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code looks good, could you please remove main and add some JUnit tests? (see https://github.com/TheAlgorithms/Java/tree/master/src/test/java/com/thealgorithms)

@siriak
Copy link
Member

siriak commented Oct 23, 2024

Fixes #5852

@Fenirok
Copy link
Author

Fenirok commented Oct 23, 2024

The code looks good, could you please remove main and add some JUnit tests? (see https://github.com/TheAlgorithms/Java/tree/master/src/test/java/com/thealgorithms)

yeah let me try

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants