Adaptive Replacement Cache (ARC) #5116
Open
+205
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
devxadarsh
requested review from
yanglbme,
vil02 and
BamaCharanChhandogi
as code owners
|
Have you read the CONTRIBUTING.md correctly? It would help if you wrote parametrized tests in a separate file in the |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #5116 +/- ##
============================================
+ Coverage 38.16% 38.24% +0.07%
- Complexity 2362 2370 +8
============================================
Files 517 518 +1
Lines 15350 15400 +50
Branches 2965 2971 +6
============================================
+ Hits 5858 5889 +31
- Misses 9205 9220 +15
- Partials 287 291 +4 ☔ View full report in Codecov by Sentry. |
src/main/java/com/thealgorithms/datastructures/caches/ARCCache.java
Outdated
Show resolved
Hide resolved
src/main/java/com/thealgorithms/datastructures/caches/ARCCache.java
Outdated
Show resolved
Hide resolved
src/main/java/com/thealgorithms/datastructures/caches/ARCCache.java
Outdated
Show resolved
Hide resolved
src/main/java/com/thealgorithms/datastructures/caches/ARCCache.java
Outdated
Show resolved
Hide resolved
|
Please ensure that tests are added to handle lines with partial coverage. |
devxadarsh
commented
Apr 24, 2024
|
You should format the code. LGTM |
It aims to provide better performance compared to traditional caching algorithms like LRU (Least Recently Used) and LFU (Least Frequently Used).
Main Method Removed for ARCCache.java
Test cases added for the ARC
….java Co-authored-by: SOZEL <[email protected]>
….java Co-authored-by: SOZEL <[email protected]>
….java Co-authored-by: SOZEL <[email protected]>
….java Co-authored-by: SOZEL <[email protected]>
Replaced private final p(Pivot) using private final int t1Capacity; private final int b1Capacity; adjustCacheSize();
updated test case for t1capacity and b1 capacity
|
Please format your code using |
vil02
requested changes
May 4, 2024
src/main/java/com/thealgorithms/datastructures/caches/ARCCache.java
Outdated
Show resolved
Hide resolved
src/main/java/com/thealgorithms/datastructures/caches/ARCCache.java
Outdated
Show resolved
Hide resolved
Updated capacity method
Updated capacity method to handle negative input
|
Please add the missing tests and update your branch. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
clang-format -i --style=file path/to/your/file.java