optimized stack array implementation

[11-aryan]

• Optimized the push operation by appending to the last element of the array instead of copying the whole array
• Removed the global variable stackArray and created a struct StackArray for it
• Modified stack_test.go file to reflect these changes

[11-aryan]

Hi,
I've made the changes as mentioned. Will this be considered this as a part of the Hacktoberfest if accepted?

[11-aryan]

Can the code style tests that failed be resolved by running gofmt -s -w stackarray.go ?

[raklaptudirm]

Yes they can be fixed that way.

[raklaptudirm]

Please export all the methods and convert the tests into black box ones.

[11-aryan]

Could you please elaborate what exactly should be black boxed and in what way ?

[raklaptudirm]

In go, you can write tests either in the packagename package or the packagename_test package. Tests are written under the packagename package when you want to test internal functionality of a package, and under the packagename_test package when you want to test the public API of a package. In your case you are testing the public API (which is why I asked you to export all the methods) and therefore should be tested under the packagename_test package, also known as black box testing.

[11-aryan]

Oh, got it! Thanks for the explanation