feat(cipher/diffiehellman): add fuzz test to key generators in diffiehellman algorithm #602
Conversation
mcaci
requested review from
siriak,
raklaptudirm,
tjgurwara99 and
yanglbme
as code owners
| f.Add(int64(5), int64(17)) | ||
| f.Fuzz(func(t *testing.T, prvKey, shrdKey int64) { | ||
| // explicitly ignoring the return error | ||
| // here we want to test that no strange behaviors are raised when executing GenerateMutualKey |
There was a problem hiding this comment.
Can you define "strange" behaviour?
I'm of the opinion that these fuzz tests are for checking the unexpected behaviour - that could only be detected once you check the errors (since there are no panics in the algorithm.)
There was a problem hiding this comment.
About the reason for these tests: it is mostly to run the function and see if it breaks for unexpected reasons like if there are any issue during the computation done in the algorithm, i.e. divisions by zero, overflows and so on. Let me know what are your thoughts on this.
There was a problem hiding this comment.
I don't think there is anything that is being checked for us to conclude that there is nothing "strange" happening. I don't think this is a change with any merit... 😓
…ehellman algorithm
|
This PR is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 5 days. |
|
This PR was closed because it has been stalled for 7 days with no activity. |
Hello, I think this is the last subpackage for the cipher package where the fuzz tests were not yet present. I added two quick fuzz tests for the key generators and tested them with 'go test ./cipher/diffiehellman/ -fuzz=FuzzGenM' and 'go test ./cipher/diffiehellman/ -fuzz=FuzzGenS' to check that the execution was getting along just fine.
Let me know if you have any feedbacks on it. Thanks again!
PR linked to issue #480