feat(cipher/caesar): add fuzzy test to caesar cipher #559
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
VictorAssunc
requested review from
siriak,
raklaptudirm,
tjgurwara99 and
yanglbme
as code owners
tjgurwara99
approved these changes
Oct 10, 2022
ok, thanks. it would be nice if you can label this PR with |
raklaptudirm
approved these changes
Oct 12, 2022
raklaptudirm
added
the
hacktoberfest-accepted
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added Fuzzy test to Caesar Cipher
I had to make a small change in the algorithm approach and treat the input text as a byte array, as the old way some characters were converted wrong. An example obtained when running fuzzy was the character
ǃ(note that this is different from!) was converted to�and not returned to normal inDecrypt.In this image you can better see the difference between the two characters (left: the one responsible for the problem; right: the normal character)
I don't know if I chose the best approach. I'm willing to change that and also give more details about the problem.
Ref #480