Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes: #196 #197

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fixes: #196 #197

wants to merge 1 commit into from

Conversation

skdotv
Copy link
Contributor

@skdotv skdotv commented Oct 15, 2022

Welcome to Dart community

Describe your change:

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Dart files are placed inside an existing directory.
  • All new algorithms have a URL in its comments that points to Wikipedia or other similar explanation.
  • If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.

@skdotv skdotv changed the title Fixes: #{$196} Fixes: #196 Oct 15, 2022
akashgk
akashgk reviewed Oct 26, 2022
View reviewed changes
sort/pigeonhole_sort.dart
@@ -21,7 +21,7 @@ void pigeonholeSort(List arr) {
int range = max - min;
range++;

List phole = new List(range);
List phole = []..length = range;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think assigning length value is not a good practice. Can we change the constructor to List.filled()

akashgk
akashgk requested changes Oct 26, 2022
View reviewed changes
Copy link
Member

@akashgk akashgk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some comments left

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@akashgk akashgk akashgk requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@skdotv @akashgk