Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: remove memory leak in sublist_search.cpp #2541

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix: remove memory leak in sublist_search.cpp #2541

wants to merge 1 commit into from
+25 −2

Conversation

vil02
Copy link
Member

@vil02 vil02 commented Sep 25, 2023

Description of Change

sublist_search.cpp has a memory leak. This PR adds the function deleteList in order to fix it.

Checklist

  • Added description of change
  • Added documentation so that the program is self-explanatory and educational - Doxygen guidelines
  • Relevant documentation/comments is changed or added
  • PR title follows semantic commit guidelines
  • Search previous suggestions before making a new one, as yours may be a duplicate.
  • I acknowledge that all my contributions will be made under the project's license.

Notes:
Removes memory leak in sublist_search.cpp.

@vil02 vil02 marked this pull request as ready for review September 25, 2023 15:28
@vil02
Copy link
Member Author

vil02 commented Sep 25, 2023

@CarlosZoft you have some recent experience with reviewing pull-requests fixing memory leaks - maybe you could have a look here as well?

realstealthninja
realstealthninja approved these changes Sep 27, 2023
View reviewed changes
Copy link
Collaborator

@realstealthninja realstealthninja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vil02 vil02 force-pushed the memory_leak_in_sublist_search_patch branch from 02f0feb to e5f8d95 Compare October 2, 2023 11:49
@github-actions GitHub Actions
Copy link
Contributor

This pull request has been automatically marked as abandoned because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@github-actions github-actions bot added the stale Author has not responded to the comments for over 2 weeks label Dec 24, 2023
@vil02
Copy link
Member Author

vil02 commented Dec 24, 2023

@Panquesito7, @realstealthninja: please dont-close.

@github-actions github-actions bot removed the stale Author has not responded to the comments for over 2 weeks label Dec 25, 2023
@vil02 vil02 force-pushed the memory_leak_in_sublist_search_patch branch from e5f8d95 to 3b8ff14 Compare January 16, 2024 07:10
@vil02 vil02 force-pushed the memory_leak_in_sublist_search_patch branch from 3b8ff14 to 2fd3c5b Compare February 12, 2024 21:10
@realstealthninja realstealthninja added dont-close This issue/pull request shouldn't be closed Improvement improvement in previously written codes bugfix Correction to existing algorithms labels Feb 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CarlosZoft CarlosZoft CarlosZoft approved these changes

@realstealthninja realstealthninja realstealthninja approved these changes

@Panquesito7 Panquesito7 Awaiting requested review from Panquesito7 Panquesito7 is a code owner

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
bugfix Correction to existing algorithms dont-close This issue/pull request shouldn't be closed Improvement improvement in previously written codes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@vil02 @CarlosZoft @realstealthninja