New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

142 remove spacy #146

Merged

yiwen-h merged 3 commits into development from 142_remove_spacy

Oct 3, 2023

Member

yiwen-h commented Oct 3, 2023

Closes #142

Using spacy tokenizer did not improve performance
It's a large package so removing from final version of package for phase 2

yiwen-h added 3 commits

October 3, 2023 12:38


          took spacy out of toml and lock files

1c07479


          took out references to spacy in code

b6cddde


          took spacy out of tests

ce3be82

yiwen-h requested a review from ChrisBeeley

October 3, 2023 12:17

yiwen-h merged commit 7eefe7c into development

3 checks passed

yiwen-h deleted the 142_remove_spacy branch

October 3, 2023 12:24

ChrisBeeley reviewed

View reviewed changes

Member

ChrisBeeley left a comment

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet