Bash alias command substitution window resize bug #5417
+33
−18
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please review the following checklist.
Docstrings on all new or modified functions / classesUpdated documentationGreetings,
I'm making this PR following a conversation with @xavierog (thanks to him) on Discord. I asked him for help regarding my TUI application.
My application was not resized correctly, the display was bugged and for example the Footer was disappearing, the thing is that I was running the Python application from a bash alias using command substitution (
alias cmd='$(python3 tui-app.py)'
), @xavierog discovered that the Textual driver was usingshutil.get_terminal_size()
to get the window size, but in that specific case, the function is failling because the command is ran from a bash command substitution.This PR aim to fix that specific (and probably uncommon) situation, I ran all tests and here is the results:
I had the same results with a fresh
Textual
clone so I don't think my changes broke any tests.