Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix memory out-of-bounds issue when multiple PAGView load the same PAG file. #2279

Merged
merged 1 commit into from
May 6, 2024

Conversation

kevingpqi123
Copy link
Collaborator

No description provided.

@codecov-commenter
Copy link

codecov-commenter commented May 6, 2024

Codecov Report

Attention: Patch coverage is 60.00000% with 4 lines in your changes missing coverage. Please review.

Project coverage is 61.80%. Comparing base (251d408) to head (ab33f5e).
Report is 18 commits behind head on main.

Files with missing lines Patch % Lines
include/pag/file.h 60.00% 0 Missing and 4 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2279      +/-   ##
==========================================
- Coverage   61.86%   61.80%   -0.07%     
==========================================
  Files         385      385              
  Lines       22063    22063              
  Branches     6422     6422              
==========================================
- Hits        13650    13635      -15     
+ Misses       4440     4436       -4     
- Partials     3973     3992      +19     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@domchen domchen merged commit 5c2da6a into main May 6, 2024
7 checks passed
@domchen domchen deleted the bugfix/kevingpqi_file branch May 6, 2024 06:30
kevingpqi123 added a commit that referenced this pull request May 6, 2024
…G file. (#2279)

Co-authored-by: kevingpqi <[email protected]>
(cherry picked from commit 5c2da6a)
kevingpqi123 added a commit that referenced this pull request May 6, 2024
…G file. (#2279)

Co-authored-by: kevingpqi <[email protected]>
(cherry picked from commit 5c2da6a)
kevingpqi123 added a commit that referenced this pull request May 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants