Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

prevent nested menu from obscuring parent when user clicks towards right edge of window #144

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

dwightkelly
Copy link

fix for issue #143

@josetaira
Copy link
Collaborator

hi @dwightkelly, thanks for your contrib. Not able to test this immediately, but before I merge it in, could you please post a screenshot of what it looks like with this change?

@dwightkelly
Copy link
Author

normal "right" mode
screen shot 2018-08-13 at 3 15 27 pm

overlapped if child menu would render off right edge of window
screen shot 2018-08-13 at 3 15 41 pm

@AlexConnolly
Copy link

This doesn't work for menus that have more than 2 levels.

image

Note how the right of the image is the edge of the screen. Will look at fixing this now, but feel free to validate too.

@AlexConnolly
Copy link

I'm using orientation left right now to resolve my issue. I guess in this circumstance, for me, it was easier to use orientation left. I couldn't find any documentation for this, though, so it would be nice to maybe be pointed in the direction or I will happily write some.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants