Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Docker build, switch to GHA #94

Merged
merged 4 commits into from
Jan 18, 2024
Merged

Docker build, switch to GHA #94

merged 4 commits into from
Jan 18, 2024

Conversation

ripexz
Copy link
Member

@ripexz ripexz commented Jan 18, 2024

  • Added Docker build to make it easier to use kommentaar standalone. This is primarily to enable getting around the requirement of having your code within $GOPATH as kommentaar is currently struggling to parse references outside it. See updated README for usage examples.
  • Switch from Travis to GHA. Primarily for making it easier to publish the Docker image to GitHub Packages.

@ripexz ripexz requested a review from a team January 18, 2024 12:33
rafaeljusto
rafaeljusto approved these changes Jan 18, 2024
View reviewed changes
Copy link
Contributor

@rafaeljusto rafaeljusto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@ripexz ripexz merged commit b8f85c6 into master Jan 18, 2024
3 checks passed
@ripexz ripexz deleted the docker branch January 18, 2024 12:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rafaeljusto rafaeljusto rafaeljusto approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ripexz @rafaeljusto