Android 12.1 #1
Open
Android 12.1 #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Change-Id: I24114565d80d1e15a7f2d5f65b770d7b5b705134
Change-Id: I84d4a5733c4ca380076cbe2b04608b69aa78f8c8
Bug: 180535575 Test: apply OTA, snapshotctl dump Change-Id: Iedd761b2f6923a56b11f9d6868d6baf569ad38d0
Original change: https://android-review.googlesource.com/c/platform/system/update_engine/+/1631917 Change-Id: Ida5a8fa561f788dfbdfba671385928dd70f7296e
Original change: https://android-review.googlesource.com/c/platform/system/update_engine/+/1631917 Change-Id: I255f8e67de07ab0e7a46b126a4634805714c3a4b
When DynamicPartitionControlAndroid is constructed, it initializes both source and target slot to -1. These values get updated during PreparePartitionsForUpdate call. And we only PreparePartitionsForUpdate() when applying an OTA or applocating space for an OTA(not when verifying OTA metadata). Which means if VerifyPayloadApplicable() is called before any call two other APIs, we could be using an "Uninitialiazed" dynamic partition control. To mitigate this problem, we pass in source_slot at ctor of DynamicPartitionControl, also make IsDynamicPartition() api take in a slot number to avoid reading uninitialized member fields. Bug: 181643302 Test: apply an OTA, abort, restart update_engine, verify a payload Change-Id: I9a8a0fe8a9aca48e91241e15bdec33a1c1228553
Original change: https://android-review.googlesource.com/c/platform/system/update_engine/+/1622020 Change-Id: I542615fc8da27cfb2ce1ac671c193f10096b2da7
Original change: https://android-review.googlesource.com/c/platform/system/update_engine/+/1622020 Change-Id: Idcd1934b22336b7afae6a059373bdb0b01c61ba8
Bug: 172911822 Test: atest ApexHandlerAndroidTest (checked that file was created) Change-Id: I8024695ebba1a9c1796c05b27a0eec3da3b3d1bc
Original change: https://android-review.googlesource.com/c/platform/system/update_engine/+/1614853 Change-Id: Iefa9b70759279eab8bb6573df205840c3bec520d
am: f057877 Original change: https://android-review.googlesource.com/c/platform/system/update_engine/+/1614853 Change-Id: I927d67667d53f9c45cc92a2e083de4ab774ed6d5
Original change: https://android-review.googlesource.com/c/platform/system/update_engine/+/1631917 Change-Id: Ie24c83f06c1efc6214793dd166f772b04ae0ac82
…am: e59ea77 Original change: https://android-review.googlesource.com/c/platform/system/update_engine/+/1622020 Change-Id: I4352c02756cb832be16a8552e68388be00b54a45
Test: th & serve an OTA with veity enabled, vabc disabled Change-Id: Ib1d5549ac615504a47c96a12b046975cfff01886
am: f057877 am: a37773e Original change: https://android-review.googlesource.com/c/platform/system/update_engine/+/1614853 Change-Id: I1ae0e4c6c43f4602a7df0bce455de4a81786a1a7
Change-Id: Idc12cd8be88fea2999672d59960d632872fc2df6
Change-Id: I4433bd8a409846cdae329635970a909c31b93c40
Original change: https://android-review.googlesource.com/c/platform/system/update_engine/+/1636220 Change-Id: I1c6886dfd6ea9fbc86655f1756ea1b28f0bf0e86
…07f9fb Original change: https://android-review.googlesource.com/c/platform/system/update_engine/+/1636220 Change-Id: I741fb6907f51d0903b43d7eeb9a45d90fcd7548b
…07f9fb am: a69c638 Original change: https://android-review.googlesource.com/c/platform/system/update_engine/+/1636220 Change-Id: I346a10fa2fe908399c74c769097d2db0abeb16d6
Change-Id: Ie8be28c5a38d90e601388635d4bd858ed4ccebb4
If we don't unmap partitions, snapuserd will keep running in the background and do nothing. Unmap partitions so that memory associated with daemon can be freed. Test: th, apply an OTA, verify that _b partitions in /dev/block/mapper are gone Change-Id: I4a75f4abe3e69f9ad2a67a78472b61cfbd77b0eb Change-Id: Icacf1699a32bf045c2b832f7c1f021d90805d676
Verity that we read everything in hashtree_data_extent before writing hash tree. Bug: 173432386 Test: th Change-Id: I00ab8053de71b13991adaa243b6cb6c7efd6e60f
Original change: https://android-review.googlesource.com/c/platform/system/update_engine/+/1648727 Change-Id: I76617236b8799c88dd83cb503177e91c9005f8ab
Original change: https://android-review.googlesource.com/c/platform/system/update_engine/+/1640819 Change-Id: I74cbb395d725d5931344b7a2bf2c10e7113d3152
Original change: https://android-review.googlesource.com/c/platform/system/update_engine/+/1648727 Change-Id: I154b305541ff3f1c99e9dd4cf4d1dad3757c4648
Original change: https://android-review.googlesource.com/c/platform/system/update_engine/+/1640819 Change-Id: I2e3dfd8726f3c47d53232c61d4c3de061686fed8
… am: ca37677 Original change: https://android-review.googlesource.com/c/platform/system/update_engine/+/1648727 Change-Id: I8d27fa6fa3f101b946b48ca6306f759918f3bc44
…661845 Original change: https://android-review.googlesource.com/c/platform/system/update_engine/+/1640819 Change-Id: I1dc71c2f467b396f013356df734ada6268ccee2a
Change-Id: I866142205afbde97bf289c9ef032fb8b8f69330f
Original change: https://googleplex-android-review.googlesource.com/c/platform/system/update_engine/+/15067039 Change-Id: I646602b643a18ec851a95c0ed46725ee82c9727b
Change-Id: I5b3e1cdef5b180d754964c5b51d248d78763c2dd
Revert "Add ramdisk_available to init_first_stage's deps" Revert "Add ramdisk_available to init_first_stage's deps" Revert "Add ramdisk_available to init_first_stage's deps" Revert "Add ramdisk_available to init_first_stage's deps" Revert "Add ramdisk_available to init_first_stage's deps" Revert "Add ramdisk_available to init_first_stage's deps" Revert "Add ramdisk_available to init_first_stage's deps" Revert "Completely migrate init first stage to Soong" Revert "Add ramdisk_available to init_first_stage's deps" Revert "Add ramdisk_available to init_first_stage's deps" Revert "Add ramdisk_available to init_first_stage's deps" Revert "Add ramdisk_available to init_first_stage's deps" Revert "Add ramdisk_available to init_first_stage's deps" Revert "Add ramdisk_available to init_first_stage's deps" Revert "Add ramdisk_available to init_first_stage's deps" Revert "Update init_first_stage" Revert "Add ramdisk_available to init_first_stage's deps" Revert "Add ramdisk_available to init_first_stage's deps" Revert "Add BOARD_BUILD_SYSTEM_ROOT_IMAGE to config vars" Revert "Add install_in_root to cc_binary" Revert "Add ramdisk_available to init_first_stage's deps" Revert submission 15071196-init_first_stage_soong Reason for revert: fixes b/192248690 Reverted Changes: I23cf4f975:Add ramdisk_available to init_first_stage's deps Icd98c7e24:Add ramdisk_available to init_first_stage's deps If9da9ba16:Add ramdisk_available to init_first_stage's deps Ibc8668029:Add ramdisk_available to init_first_stage's deps I3b4b8c475:Add ramdisk_available to init_first_stage's deps I59cd149e0:Completely migrate init first stage to Soong I36d789578:Add ramdisk_available to init_first_stage's deps I2a0daa612:Add BUILD_USES_RECOVERY_AS_BOOT to soong config Ic76c325ce:Directly create ramdisk dirs in ramdisk image rule... I4c5374deb:Add BOARD_BUILD_SYSTEM_ROOT_IMAGE to config vars I8aab5faf3:Add ramdisk_available to init_first_stage's deps I9d5a10661:Add ramdisk_available to init_first_stage's deps Iaa2edeb4a:Add ramdisk_available to init_first_stage's deps I7cb582ca0:Update init_first_stage I06091d15e:Add ramdisk_available to init_first_stage's deps I8bdb8dda3:Add ramdisk_available to init_first_stage's deps I7436b8dd1:Add ramdisk_available to init_first_stage's deps I39693fd86:Add ramdisk_available to init_first_stage's deps I0a9ba90f0:Add ramdisk_available to init_first_stage's deps Ib66b4c4ea:Add ramdisk_available to init_first_stage's deps I31ce63d23:Add ramdisk_available to init_first_stage's deps Icb580f97c:Add ramdisk_available to init_first_stage's deps I044a075b7:Add ramdisk_available to init_first_stage's deps I33164a7e7:Fix ndk and aml arch order Ib8d92904a:Add ramdisk_available to sysprop_library Ibc3516453:Add install_in_root to cc_binary Change-Id: I7c7f5feaca6e8e78a3334932847da14e46e4f01a
This also adds a manual call to WriteState(). If update_engine crashes or the device reboots, it's possible that certain stats (such as the COW file stats) will be gone by the time the merge state is recovered. Forcing a write prevents this. Note that the write was previously implicit in set_cow_file_size, but is now explicit before calling InitiateMerge(). Bug: 188909957 Test: manual test Change-Id: I27cdc72272a9fa4ff5df4968e200fc14f63d0146 Merged-In: I27cdc72272a9fa4ff5df4968e200fc14f63d0146
Bug: 188909957 Test: manual test Change-Id: I108c20cf1e092478be2ae59701514f32d9b0a9f3 Merged-In: I108c20cf1e092478be2ae59701514f32d9b0a9f3
Original change: https://googleplex-android-review.googlesource.com/c/platform/system/update_engine/+/15178752 Change-Id: I5d8e8641fd4083b63354db5e96c97f547c332d05
…D. am: cfd7c0f Original change: https://googleplex-android-review.googlesource.com/c/platform/system/update_engine/+/15178680 Change-Id: I41e1e8165df78e656258c74a9661a9e6823d9a1a
Change-Id: I42ea76ecaaeab7962b8e9af5d7d564b6d0b5ab7d
…o sc-dev am: 04206a9 Original change: https://googleplex-android-review.googlesource.com/c/platform/system/update_engine/+/15167755 Change-Id: I945e618f872acaa6b0c57efa1ba3942c6cc04187
Change-Id: I30d873a8bfdd5cb0996d575adf89975aa8a4ce56
Test: th Bug: 194661607 Bug: 194779085 Change-Id: I0e37136313914f1ee9a4eae0e5db59807adc7dc5 Merged-In: I0e37136313914f1ee9a4eae0e5db59807adc7dc5
Original change: https://googleplex-android-review.googlesource.com/c/platform/system/update_engine/+/15401790 Change-Id: I8b5fa023271d9685d37a45646169abda80d24a40
Change-Id: I4df8fea97335e94d5f43d571ddbac43ad7b99db6
This reduces size of SP2A.210827.001-to-SP2A.210903.001.zip OTA package from 83MB to 66MB. Which is ~21% improvement. Tests: th Bug: 199920825 (cherry picked from commit dc1f258) Change-Id: I10fa03401e5920c633c3ce5d6cf737489fecb6de Merged-In: I10fa03401e5920c633c3ce5d6cf737489fecb6de
Original change: https://googleplex-android-review.googlesource.com/c/platform/system/update_engine/+/15829227 Change-Id: I2cb2849e061453ce1fed2c1cbbf92b52aad441be
Change-Id: I2dcfdf37efd292a57585c0f5ab1861867beaacff
Change-Id: I0ce626ef993c2a7c87e03f705ef2e866a3391db1
Change-Id: Ie450f500460fca282a78f338a4b50f55dceed450
Change-Id: I19800c02cd4f26ae54c35a45ef8bc927459d5672
Change-Id: I894c680f5d179b715cd3e4330045d81a40f21732
…in update file Change-Id: Icb48720791812afed7741eb02ab15176f60d7350 (cherry picked from commit 70af8d5)
Change-Id: I89e80641a6154b5de4ecae6ccaf9b01cd73b0036
Change-Id: I33e38472579a145bb6858963eed74d96ee7078a2
These commits break full payload zip flashing on multiple devices ---------- Revert "conditionally allow creating snapshots for incrementals" This reverts commit 37a06f4. Revert "force PrepareSnapshotPartitionsForUpdate to fail in recovery" This reverts commit f283598. Change-Id: Ic54d7d31082c9b7722cc1e7c30660deea00b0d5b
Change-Id: I6d55638812cac29ea4d4cdd79b932a3f15c42b0a
Allows incremental update zips to be installed on virtual AB devices Change-Id: I5b0115e50967cdacf47f13f5fc0107580ff52a7d
Change-Id: I96cc42fe22a460a0af834a30a335c3f190fc0e58
The override is needed in cases where update_engine erroneously concludes that there isn't sufficient space for dynamic partitions. This prevents some ROMs from being flashed. This patch allows the available space to be overridden, via a prop (ro.dynamic.full_size). In a typical situation where this problem occurs, you will see something like this in the recovery log: 'update_engine_sideload E 12-17 04:06:00 809 809 [ERROR:dynamic_partition_control_android.cc(830)] The maximum size of all groups for the target slot (9126805504) has exceeded allocatable space for dynamic partitions 9125756928' So, update_engine has used a calculation of the allocatable space that doesn't match the actual available space. In this example, running "resetprop ro.dynamic.full_size 9126805504" via runatboot.sh or postrecoveryboot.sh will override the allocatable space and allow the ROM to flash. If the prop is used, the override will only be triggered if the value supplied is higher than the calculated allocatable space. If the prop is not used at all, then everything will carry on as normal. Change-Id: I25e69d416c3cd0c766901bed0119e74b4708fbca
bigbiff
pushed a commit
that referenced
this pull request
Nov 2, 2024
Current check point works by writing different prefs to different files under a pending directory, and rename the pending directory to actual pref directory afterwards to achieve atomicity. It has two pitfalls: 1. Before the rename() call, existing prefs dir must be rm -rf'ed , this deletion process isn't atomic. If device rebooted during rm -rf, we will end up with a partially deleted old pref. 2. fsync() on the parent directory is needed after rename() This CL addresses both issues. For #1, we rename() the old pref dir to a tmp dir first, and then rm -rf the tmp dir. Upon device restart, if the current prefs dir is empty, we can simply rename() the pending directory to actual pref directory. Test: th Bug: 295252766 Change-Id: Ic671a18245986c579b51d7443c3e8c10e206c448
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
H