Add languages to ll #122
Closed
Add languages to ll #122
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nic-olo
reviewed
Jun 9, 2024
android_app/app/src/main/java/com/teamopensmartglasses/convoscope/convoscopebackend/Config.java
Outdated
Show resolved
Hide resolved
nic-olo
reviewed
Jun 9, 2024
|
Is this PR going to add the other languages as well? Let's name PRs better to explain what they're doing. |
Added more commonly used languages: German, Arabic, Korean, Italian, Turkish, Portuguese
|
Did you test all the languages to make sure the dictionaries work on the backend? The build.gradle change is still in here, please remove it. Otherwise looks good! |
|
Also, there needs to an SGM commit that adds the new languages to the ASR files. |
Mostly copy pasted from Language Learning Agent. Changed the prompt and some variable names. Also changed a typo in Language Learning Agent
remove build.gradle change
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
added french language learning