Use kotlin auto-derived equals #13
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
equals() is the same as comparing each field, so we can use the Kotlin impl, same for hashCode()
Profpatsch
force-pushed
the
use-auto-derived-equals
branch
from
aa0242e to
70cc364
Compare
ShareASmile
added
the
code quality
Profpatsch
force-pushed
the
use-auto-derived-equals
branch
from
70cc364 to
3405892
Compare
|
Note: it is important that the classes are |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Kotlin can derive
hashCodeandequalsautomatically, I assume these were a leftover from a time when the code was still in Java?In case some fields should be ignored for equality, you could put them in the body of the class, but nothing here ignored any fields it looks like.