Remove Checkstyle suppressions file and fix too-long links #843
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Stypox
requested changes
May 2, 2022
.../java/org/schabi/newpipe/extractor/services/bandcamp/extractors/BandcampExtractorHelper.java
Show resolved
Hide resolved
extractor/src/main/java/org/schabi/newpipe/extractor/services/youtube/ItagItem.java
Show resolved
Hide resolved
I can use the |
Stypox
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In 24e8399 and 8c1041d, violations of the Checkstyle line length rule have been added (because the lines were not matching the lines in the Checkstyle suppressions file). These changes causes right now a compile error.
This PR fixes these errors by splitting or reducing the corresponding lines in the character limit per line.
It also removes the usage of Checkstyle suppressions file and allows now usage of
// CHECKSTYLE:OFFand// CHECKSTYLE:ONcomments to suppress remaining Checkstyle false errors when usage of@SuppressWarnings("checkstyle:CheckstyleRule")is not possible (like in #833).