Youtube search filters #124

Bluesir9 · 2018-11-09T15:11:52Z

I carefully read the contribution guidelines and agree to them.
I did test the API against NewPipe.
I agree to ASAP create a PULL request for NewPipe for making in compatible when I changed the api.

- Added new logic to implement sort and search filters for YouTube search filters in YoutubeSearchQueryHandlerFactory. - Corrected some typos in SearchQueryHandlerFactory. - Changed test cases affected by changes made to YoutubeSearchQueryHandlerFactory. - Added todo items for the 2 primary test cases in YoutubeSearchQHTest.

- Added ability to handle more filters. - Added test cases to appropriately test the new filters implemented in combination with the available sorters.

theScrabi · 2018-11-09T15:19:15Z

You can find a description on how to test the changes on the frontend here: https://teamnewpipe.github.io/documentation/04_Run_changes_in_App/

…dded Base64 class in YoutubeSearchQueryHandlerFactory

Bluesir9 · 2018-11-10T13:58:49Z

@theScrabi Have tested the changes on the app and made necessary changes.

theScrabi · 2018-11-12T17:29:50Z

All right thx :)

TobiGr

@Bluesir9 I found some time to take a look at your changes. As said before, I am not that familiar with the extractor, but I'll try my best to give you detailed feedback. In case it sounds like nonsense, please tell me. There are so many largre PRs to review atm, so I might have missed something important.

I didn't test the changes yet, but the code looks quite mature.

I have one question about the added filters. You added following filters:

Time: last hour, today, this week, this month, this year

Type/Content: video, channel, playlist, movie, show,

Duration: short, long

Sorting: relevance, rating, upload date, view count

Do you intend to implement the features filter with
live, 4K, HD, Subtitles/CC, Creative Commons, 360°, VR180, 3D, HDR, location?

.../schabi/newpipe/extractor/services/youtube/linkHandler/YoutubeSearchQueryHandlerFactory.java

extractor/src/main/java/org/schabi/newpipe/extractor/utils/Base64.java

.../schabi/newpipe/extractor/services/youtube/search/YoutubeSearchExtractorChannelOnlyTest.java

.../schabi/newpipe/extractor/services/youtube/linkHandler/YoutubeSearchQueryHandlerFactory.java

- Fixed indendation issue in YoutubeSearchQueryHandlerFactory and YoutubeSearchQHTest. - Added Features filter type and filter.

- Fixed handling for features content filters. - Added test cases to check for whether feature content filters are working fine.

Bluesir9 · 2018-12-08T18:55:51Z

@TobiGr For whatever reason "Feature" filters were not working with the changes I had done last time around, so in the interest of time I removed them last minute. I have implemented them now in the last couple of commits and its working fine. Have also added tests for the same.

- Added license header to Base64 class. - Added Apache license for AOSP project in a different directory.

extractor/src/main/java/org/schabi/newpipe/extractor/utils/Base64.java

TheAssassin · 2018-12-16T16:47:13Z

Not sure if you consider this good style, but let me assure you, it's not, it's the worst I've seen in quite a while, actually. The first line of your commit is what is visible from e.g., git log --oneline, etc. Consider it the heading of your commit, it's the title that is supposed to show a reader what has been changed in a commit. Even pretty nonsense comments which are at least different from each other are easier to work with, they can at least

Please see https://chris.beams.io/posts/git-commit/ or https://dev.to/pavlosisaris/git-commits-an-effective-style-guide-2kkn how to write better commit messages.

Also, please try to commit one change at a time, not multiple. Every time you need a bullet point list to describe your changes, you're probably trying to commit too much at once. This principle is also referred to as "atomic commits". See e.g., https://medium.com/@fagnerbrack/one-commit-one-change-3d10b10cebbf, for more information.

Bluesir9 · 2018-12-16T16:55:40Z

@TheAssassin Point(s) taken.

…lass file

.../schabi/newpipe/extractor/services/youtube/linkHandler/YoutubeSearchQueryHandlerFactory.java

theScrabi

Please also swtich to dev branch.

extractor/src/main/java/org/schabi/newpipe/extractor/utils/Base64.java

theScrabi · 2018-11-13T12:01:24Z

.../schabi/newpipe/extractor/services/youtube/linkHandler/YoutubeSearchQueryHandlerFactory.java

+        Movie(FilterType.Content,(byte)0x04),
+        Show(FilterType.Content,(byte)0x05),
+
+        Hour(FilterType.Time,(byte)0x01),


NewPipe can not handle key value pair filter yet :/

I am not sure what you mean but this works out if the box. Albeit it looks kinda bad:

Yes this is the issue i ment, it is not possible to add or remove filters like key values. This messes up the UI as you see. The UI should be made ready to handle these filters.

Maybe we could implement the filters at 2 levels? We would initially ask the user to select a FilterType and after they have chosen that, we can ask them the exact filter they wish to apply falling under that FilterType?

So, clicking on the menu icon the first time, will load a list containing Content, Time, Duration, Feature. If the user chooses Duration, then we will show a second list containing Short, Long. And when the user chooses one of those options, then the search is triggered. Does that make sense?

Let's finish this PR. 🎉 Thanks for being patient!

I am working on a proper design for the filters. This might take until next Sunday, because the new semesters is about to start and thus there are a bunch of other things to do. But I would not recommend to have endless lists. They come with bad UI/UX, because it is hard to get all the (important) information.

FYI:

6 Best Practices forMobile App Search Filtering

Filter and Sorting Best Practices on Mobile

Search, Sort and Filter - Mobile Design Pattern Gallery

Collection of various screenshots

animations

@TobiGr Of course, take your time. I was just surprised and happy that it worked functionally out of the box.

I put my UI ideas into this issue in the app repo. I guess a UI discussion fits better into the other repo.

.../schabi/newpipe/extractor/services/youtube/linkHandler/YoutubeSearchQueryHandlerFactory.java

third-party-licenses/AOSP-APACHE-LICENSE-V2.0

.../schabi/newpipe/extractor/services/youtube/linkHandler/YoutubeSearchQueryHandlerFactory.java

…ff Apache Commons Codec library

… usage in Android

…gument non null

Bluesir9 · 2019-03-23T18:55:27Z

While testing I found that the app is throwing an error in case of some filters(4K only for now). I will look into this and potentially push fixes for the same by tomorrow.

…se correct titles instead of name when matching elements.

wb9688 · 2020-04-19T13:35:47Z

Closing as it's based on YouTube's old site, introduces a new dependency which isn't neccessary, and there being no proper UI for it in NewPipe. Feel free to open a new PR in the future.

Bluesir9 added 4 commits October 19, 2018 12:10

Changes made:

d18c68a

- Added ability to handle more filters. - Added test cases to appropriately test the new filters implemented in combination with the available sorters.

Synced changes from master into youtube_search_filters branch

7bab982

Added .java-version file to gitignore and removed it from repo

93239eb

Bluesir9 added 2 commits November 10, 2018 14:08

Merge branch 'master' into youtube_search_filters

e788a0c

Removed usage of DataTypeConverter class and replaced it with newly a…

78bb968

…dded Base64 class in YoutubeSearchQueryHandlerFactory

Merge branch 'master' into youtube_search_filters

e906c37

vishan-seru-porter mentioned this pull request Dec 4, 2018

please add filters to search functionality TeamNewPipe/NewPipe#110

Closed

TobiGr reviewed Dec 7, 2018

View reviewed changes

Bluesir9 added 2 commits December 8, 2018 22:03

Changes made:

f71b62f

- Fixed indendation issue in YoutubeSearchQueryHandlerFactory and YoutubeSearchQHTest. - Added Features filter type and filter.

Changes made:

75ad8f9

- Fixed handling for features content filters. - Added test cases to check for whether feature content filters are working fine.

Changes made:

98b67a4

- Added license header to Base64 class. - Added Apache license for AOSP project in a different directory.

TheAssassin reviewed Dec 16, 2018

View reviewed changes

extractor/src/main/java/org/schabi/newpipe/extractor/utils/Base64.java Outdated Show resolved Hide resolved

Added top level comment explaining modifications made to the Base64 c…

b02ca4a

…lass file

TobiGr reviewed Dec 27, 2018

View reviewed changes

.../schabi/newpipe/extractor/services/youtube/linkHandler/YoutubeSearchQueryHandlerFactory.java Show resolved Hide resolved

Bluesir9 and others added 2 commits January 3, 2019 23:07

Fix bug where index is used incorrectly

6e8515d

Merge branch 'master' into youtube_search_filters

5464d73

theScrabi requested changes Mar 23, 2019

View reviewed changes

Replace Base64 class introduced with Base64 encoding implementation o…

cd38c1b

…ff Apache Commons Codec library

Bluesir9 changed the base branch from master to dev March 23, 2019 14:50

Bluesir9 added 3 commits March 23, 2019 20:23

Merge branch 'dev' into youtube_search_filters

56366eb

Create Base64Utils to work around alleged legacy apache commons codec…

7c80354

… usage in Android

Add comment explaining purpose of Base64Utils and make bytes array ar…

8152ccf

…gument non null

TobiGr mentioned this pull request Mar 27, 2019

Search filter UI TeamNewPipe/NewPipe#2251

Open

Altered test cases to test all filters and sorters individually and u…

55b126a

…se correct titles instead of name when matching elements.

Stypox mentioned this pull request Aug 18, 2019

[Feature Request] I would like to be able to filter search results by video quality TeamNewPipe/NewPipe#1396

Closed

TobiGr added enhancement New feature or request youtube service, https://www.youtube.com/ labels Dec 27, 2019

Bluesir9 added 3 commits December 30, 2019 22:49

Merge remote-tracking branch 'upstream/dev' into youtube_search_filters

2b771cb

Undo unnecessary change made to gitignore file

4cfd07b

Change Movie filter name to Film and Show filter name to Programme

68f9547

B0pol mentioned this pull request Jan 17, 2020

[FR] support search URLs TeamNewPipe/NewPipe#2313

Open

3 tasks

wb9688 closed this Apr 19, 2020

B0pol mentioned this pull request May 8, 2020

YouTube search filters #106

Open

opusforlife2 mentioned this pull request Jun 7, 2021

[HELP NEEDED] Major planned/missing features TeamNewPipe/NewPipe#6448

Open

34 tasks

litetex mentioned this pull request Oct 24, 2021

Ridiculous, when search reveals a vast amount of hits that cannot be sorted! TeamNewPipe/NewPipe#7306

Closed

evermind-zz mentioned this pull request Aug 19, 2022

Rework content and sort filter framework #904

Open

3 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Youtube search filters #124

Youtube search filters #124

Bluesir9 commented Nov 9, 2018 •

edited

Loading

theScrabi commented Nov 9, 2018

Bluesir9 commented Nov 10, 2018

theScrabi commented Nov 12, 2018

TobiGr left a comment

Bluesir9 commented Dec 8, 2018

TheAssassin commented Dec 16, 2018

Bluesir9 commented Dec 16, 2018 •

edited

Loading

theScrabi left a comment

theScrabi Nov 13, 2018

Bluesir9 Mar 23, 2019

theScrabi Mar 23, 2019

Bluesir9 Mar 24, 2019

TobiGr Mar 24, 2019

Bluesir9 Mar 24, 2019

TobiGr Mar 27, 2019

Bluesir9 commented Mar 23, 2019

wb9688 commented Apr 19, 2020

Youtube search filters #124

Youtube search filters #124

Conversation

Bluesir9 commented Nov 9, 2018 • edited Loading

theScrabi commented Nov 9, 2018

Bluesir9 commented Nov 10, 2018

theScrabi commented Nov 12, 2018

TobiGr left a comment

Choose a reason for hiding this comment

Bluesir9 commented Dec 8, 2018

TheAssassin commented Dec 16, 2018

Bluesir9 commented Dec 16, 2018 • edited Loading

theScrabi left a comment

Choose a reason for hiding this comment

theScrabi Nov 13, 2018

Choose a reason for hiding this comment

Bluesir9 Mar 23, 2019

Choose a reason for hiding this comment

theScrabi Mar 23, 2019

Choose a reason for hiding this comment

Bluesir9 Mar 24, 2019

Choose a reason for hiding this comment

TobiGr Mar 24, 2019

Choose a reason for hiding this comment

Bluesir9 Mar 24, 2019

Choose a reason for hiding this comment

TobiGr Mar 27, 2019

Choose a reason for hiding this comment

Bluesir9 commented Mar 23, 2019

wb9688 commented Apr 19, 2020

Bluesir9 commented Nov 9, 2018 •

edited

Loading

Bluesir9 commented Dec 16, 2018 •

edited

Loading