Make thumbnails' scaleType fitCenter
#8573
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Otherwise e.g. shorts thumbnails would be cropped too much
AudricV
added
feature request
5 tasks
|
Kudos, SonarCloud Quality Gate passed!
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is it?
Description of the changes in your PR
Since the last extractor update (which included TeamNewPipe/NewPipeExtractor#810), YouTube thumbnail urls point to thumbnails with the original aspect ratio preserved (16:9 for normal videos, 9:16 for shorts I think). Before this change, some other "legacy" urls were obtained, which instead pointed to images with pre-added black bars for shorts to make them all 16:9. This change revealed that NewPipe was not treating correctly images with aspect ratios different than 16:9, showing only their center part using the
scaleType="centerCrop"property. Instead I usedscaleType="fitCenter", see the difference in the screenshots.SoundCloud and Bandcamp square thumbnails also look better.
I also made it so that playlist thumbnails align left, so that a smaller part of the thumbnail is hidden under the black bar on the right.
Before/After Screenshots/Screen Record
Fixes the following issue(s)
APK testing
The APK can be found by going to the "Checks" tab below the title. On the left pane, click on "CI", scroll down to "artifacts" and click "app" to download the zip file which contains the debug APK of this PR.
Due diligence