Updated extractor to latest revision and fix compile errors #8531
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
litetex
force-pushed
the
fix-extractor-compile-errors-846
branch
3 times, most recently
from
506d8cc to
b4f3db6
Compare
Stypox
reviewed
Jun 21, 2022
| .findFirst() | ||
| .map(StreamingService::getServiceInfo) | ||
| .map(StreamingService.ServiceInfo::getName) | ||
| .orElse("<unknown>"); |
There was a problem hiding this comment.
Wouldn't recommend:
- This should never happen in the first place (however it's possible because we use
ints instead of valid objects) - We are inside a static method we would need some kind of context here (and in all subsequent calls)
- I don't think we have to translate this
- It was a hardcoded string before
litetex
force-pushed
the
fix-extractor-compile-errors-846
branch
from
b4f3db6 to
04e8e03
Compare
|
Kudos, SonarCloud Quality Gate passed! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is it?
Description of the changes in your PR
APK testing
The APK can be found by going to the "Checks" tab below the title. On the left pane, click on "CI", scroll down to "artifacts" and click "app" to download the zip file which contains the debug APK of this PR.
Relies on the following changes
Due diligence