Migrate “History and Cache” to Jetpack Compose #11494
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@snaik20 can you review this PR? |
Isira-Seneviratne
requested changes
Sep 2, 2024
Comment on lines
+8
to
+18
| class OpenErrorActivity( | ||
| private val context: Context, | ||
| ) { | ||
| operator fun invoke(errorInfo: ErrorInfo) { | ||
| val intent = Intent(context, ErrorActivity::class.java) | ||
| intent.putExtra(ErrorActivity.ERROR_INFO, errorInfo) | ||
| intent.addFlags(Intent.FLAG_ACTIVITY_NEW_TASK) | ||
|
|
||
| context.startActivity(intent) | ||
| } | ||
| } |
There was a problem hiding this comment.
This would be better as a static method in the error activity class itself.
Comment on lines
+31
to
+37
| val clickModifier = if (enabled) { | ||
| Modifier.clickable { onClick() } | ||
| } else { | ||
| Modifier | ||
| } | ||
| Row( | ||
| modifier = clickModifier.then(modifier), |
There was a problem hiding this comment.
Suggested change
| val clickModifier = if (enabled) { | |
| Modifier.clickable { onClick() } | |
| } else { | |
| Modifier | |
| } | |
| Row( | |
| modifier = clickModifier.then(modifier), | |
| Row( | |
| modifier = Modifier | |
| .clickable(enabled, onClick = onClick) | |
| .then(modifier), |
Comment on lines
+22
to
+31
| ) = ComposeView(requireContext()).apply { | ||
| setViewCompositionStrategy(ViewCompositionStrategy.DisposeOnViewTreeLifecycleDestroyed) | ||
| setContent { | ||
| AppTheme { | ||
| HistoryCacheSettingsScreen( | ||
| modifier = Modifier.fillMaxSize() | ||
| ) | ||
| } | ||
| } | ||
| } |
There was a problem hiding this comment.
Suggested change
| ) = ComposeView(requireContext()).apply { | |
| setViewCompositionStrategy(ViewCompositionStrategy.DisposeOnViewTreeLifecycleDestroyed) | |
| setContent { | |
| AppTheme { | |
| HistoryCacheSettingsScreen( | |
| modifier = Modifier.fillMaxSize() | |
| ) | |
| } | |
| } | |
| } | |
| ) = content { | |
| AppTheme { | |
| HistoryCacheSettingsScreen(modifier = Modifier.fillMaxSize()) | |
| } | |
| } |
This requires the Fragment Compose dependency.
Comment on lines
+1
to
+7
| package org.schabi.newpipe.settings.domain.usecases.get_preference | ||
|
|
||
| import kotlinx.coroutines.flow.Flow | ||
|
|
||
| fun interface GetPreference<T> { | ||
| operator fun invoke(key: Int, defaultValue: T): Flow<T> | ||
| } |
There was a problem hiding this comment.
Using DataStore might be a better option instead of adding custom classes for handling preferences.
Profpatsch
changed the title
AudricV
changed the title
Profpatsch
force-pushed
the
history_cache_compose
branch
from
89576ad to
c3aa4e7
Compare
|
I rebased on current refactor & squashed, but I can’t get it to work. The hilt library is throwing weird injection errors: |
|
Something I noticed: the old implementation seems to be still around, don’t we want to remove it? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is it?
Description of the changes in your PR
Before/After Screenshots/Screen Record
Before:
After:
Fixes the following issue(s)
APK testing
The APK can be found by going to the "Checks" tab below the title. On the left pane, click on "CI", scroll down to "artifacts" and click "app" to download the zip file which contains the debug APK of this PR. You can find more info and a video demonstration on this wiki page.
Due diligence