Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release v0.25.0 (please TEST!) #9712

Closed
3 tasks done
Stypox opened this issue Jan 22, 2023 · 33 comments
Closed
3 tasks done

Release v0.25.0 (please TEST!) #9712

Stypox opened this issue Jan 22, 2023 · 33 comments

Comments

@Stypox
Copy link
Member

Stypox commented Jan 22, 2023

Testing for regressions

Debug APK (built by @Stypox): NewPipe_v0.25.0_RC2_debug.zip
Release APK (built and signed by @Stypox): NewPipe_v0.25.0_RC2_release.zip
Please report only regressions (i.e. new issues) here, not issues that were already present in previous releases!

TODO

NewPipeExtractor version

This version of NewPipe will ship with NewPipeExtractor commit 7e793c11aec46358ccbfd8bcfcf521105f4f093a (still WIP)

App changelog

New

Improved

Fixed

Localization

Development

@Stypox Stypox pinned this issue Jan 22, 2023
@tsiflimagas
Copy link
Contributor

tsiflimagas commented Jan 22, 2023

Confirmation from others might be needed, but when I resize the popup player, its size jumps around for a moment, something like flashing, and after that it ends up away from one of the fingers, making swiping-adjusting uncomfortable.

Edit: I just thought to install a debug build from 0.24.1 release and test it, and the same happens, so I guess you can ignore this report. Either I never noticed this happens, or it has something to do with my current system.

@peat80
Copy link

peat80 commented Jan 22, 2023

Not really an problem, more an cosmetical issue:

Since the introduction of the new card view and raising the item size on tv (previously 5, now 3 items per row) the resolution of the thumbnails is way too low. They look blurry and show artifacts. People may be complaining about that. 🙄🤭

So would it be possible to get
TeamNewPipe/NewPipeExtractor#889
completed and merged before releasing 0.25?
Not necessary ofc, but the new release would look more polished with better tumbs. 😎

Anyways, great job so far. 😁👍

@SameenAhnaf
Copy link
Collaborator

Clicking twice is now required for showing video interface. First one for showing soft buttons, second one for video interface. This should not be the case as swiping from soft buttons' edge shows soft buttons.

Screenrecorder-2023-01-22-19-38-46-579.mp4

@SameenAhnaf
Copy link
Collaborator

Not sure if Hide notch on full screen player is included as a feature. If so, make it optional. Some users were facing #7913 when this feature was introduced

@killerrook

This comment was marked as off-topic.

@moriel5
Copy link

moriel5 commented Jan 23, 2023

@peat80 I something similar on my Razer Phone 2.

While the items per row under the subscription tab remained the same (4), they are now much larger and very blurry.

Personally, I would have preferred for them to remain the same size, but to reduce the amount of space between them by fitting 5 items (I have the space for that, since I set everything to be at the smallest size in the system settings).

@SameenAhnaf
Copy link
Collaborator

Clicking on Open In Browser shows a toast No app on your device can open this

@theScrabi

This comment was marked as resolved.

@Jean-BaptisteC
Copy link

Clicking on Open In Browser shows a toast No app on your device can open this

Check this #9615

@SameenAhnaf
Copy link
Collaborator

Well, #9615 doesn't seem to be device specific. My device is on MIUI 12.5.

@Jean-BaptisteC
Copy link

This bug is specific to Android 13 :)

@SameenAhnaf
Copy link
Collaborator

SameenAhnaf commented Jan 24, 2023

But my device is on Android 11, MIUI 12.5

@Monstanner
Copy link

There is a known issue with the new ExoPlayer version on certain Android versions/devices. This makes the video stutter at a certain resolution. I have tested the new version of NewPipe on my Device (Nokia 6.1 Android 10 Vanilla) and from a resolution of 720p60fps and higher, the problem is present. Zapp also has the problem and is waiting for an update of ExoPlayer which may fix the problem. Xtra has/had the problem too, but was able to solve it with a hadware decoder.

@TeamNewPipe TeamNewPipe deleted a comment from goyalyashpal Jan 26, 2023
@PrinceRaj53

This comment was marked as off-topic.

@SameenAhnaf

This comment was marked as resolved.

@PrinceRaj53

This comment was marked as resolved.

@SameenAhnaf

This comment was marked as resolved.

@js290

This comment was marked as off-topic.

@hamzaarbeed

This comment was marked as off-topic.

@Stypox
Copy link
Member Author

Stypox commented Jan 29, 2023

I published Release Candidate 2, which includes these changes:

@Stypox
Copy link
Member Author

Stypox commented Jan 29, 2023

So would it be possible to get TeamNewPipe/NewPipeExtractor#889 completed and merged before releasing 0.25?

@peat80 Definitely not, unfortunately. It will take a while ;-)

Clicking twice is now required for showing video interface. First one for showing soft buttons, second one for video interface. This should not be the case as swiping from soft buttons' edge shows soft buttons.

@SameenAhnaf This is likely caused by #8894. @Isira-Seneviratne could you look into it?

@Isira-Seneviratne
Copy link
Member

Isira-Seneviratne commented Jan 29, 2023

@Isira-Seneviratne could you look into it?

Sure, I'll take a look when I get home.

@Isira-Seneviratne
Copy link
Member

Isira-Seneviratne commented Jan 29, 2023

@SameenAhnaf On which Android version(s) did you get this issue? I checked on Android 6 and 13, and I didn't face any issues.

@SameenAhnaf
Copy link
Collaborator

my device is on Android 11, MIUI 12.5

@Isira-Seneviratne
Copy link
Member

Thanks for the info, I'll look into the issue.

@JozKov

This comment was marked as off-topic.

@SameenAhnaf

This comment was marked as off-topic.

@Isira-Seneviratne
Copy link
Member

Isira-Seneviratne commented Feb 3, 2023

@SameenAhnaf I checked on a device running Android 11, and the system bars displayed fine when tapping the video player once.

device-2023-02-03-193914.mp4

@pymen pymen mentioned this issue Feb 3, 2023
6 tasks
@SameenAhnaf
Copy link
Collaborator

Then, something is wrong with MIUI, I believe. My device is Redmi Note 8 Pro. Sharing info expected it might help.

IMG_20230203_201649

@Stypox
Copy link
Member Author

Stypox commented Feb 7, 2023

I tried once again to reproduce the two issues that SameenAhnaf is having on MIUI, but since I have no such device myself, I couldn't reproduce. So for now I'm publishing this release, then we'll see if someone is able to fix those issues in the next release.

@peat80
Copy link

peat80 commented Feb 7, 2023

NewPipe #9615
seems to affect android tv too (latest nightlys and release candidates of 0.25).
Version 0.24.1 opens installed browser (tv bro) fine.

Edit:
Apk from #9758 does work.

@Stypox Stypox closed this as completed Feb 8, 2023
@Wazhai
Copy link

Wazhai commented Feb 9, 2023

0.25 isn't on your F-Droid repo yet
https://newpipe.net/FAQ/tutorials/install-add-fdroid-repo/

@TobiGr
Copy link
Contributor

TobiGr commented Feb 9, 2023

Sorry for the delay. The update is available trough our F-Droid repo now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests