Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update scrollToIndex center-alignment #864

Merged
merged 3 commits into from
Dec 16, 2024

Conversation

christriants
Copy link
Contributor

@christriants christriants commented Oct 27, 2024

With the assumption that the current-behavior is not intended, I opened this PR to correct the align: center behavior of scrollToIndex to align the scroll item's center, not its top, with the center of the list.

Video of issue:
https://github.com/user-attachments/assets/7b2445d7-e08e-4eee-aa97-3e454409214c

Video of fix:
https://github.com/user-attachments/assets/607a619e-fc24-4fb4-8c9a-18ec35c917af

@christriants
Copy link
Contributor Author

Hi, @piecyk @kouts. Mind taking a look at this change, if you get a moment? I hope this is helpful, but I am not sure if the current behavior is actually intended or not.

@jacobclyne
Copy link

Can we please get an update on this? 🥺 @piecyk @kouts

Copy link

nx-cloud bot commented Dec 16, 2024

☁️ Nx Cloud Report

CI is running/has finished running commands for commit bd21dd9. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution


✅ Successfully ran 2 targets

Sent with 💌 from NxCloud.

Copy link

pkg-pr-new bot commented Dec 16, 2024

Open in Stackblitz

More templates

@tanstack/angular-virtual

npm i https://pkg.pr.new/@tanstack/angular-virtual@864

@tanstack/lit-virtual

npm i https://pkg.pr.new/@tanstack/lit-virtual@864

@tanstack/solid-virtual

npm i https://pkg.pr.new/@tanstack/solid-virtual@864

@tanstack/react-virtual

npm i https://pkg.pr.new/@tanstack/react-virtual@864

@tanstack/svelte-virtual

npm i https://pkg.pr.new/@tanstack/svelte-virtual@864

@tanstack/virtual-core

npm i https://pkg.pr.new/@tanstack/virtual-core@864

@tanstack/vue-virtual

npm i https://pkg.pr.new/@tanstack/vue-virtual@864

commit: bd21dd9

@piecyk piecyk merged commit b5c99b2 into TanStack:main Dec 16, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

scrollToIndex center - incorrect align
3 participants