Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add isDesc to sortingFn #5411

Closed
wants to merge 1 commit into from
Closed

Conversation

tychenjiajun
Copy link
Contributor

See #2371

Copy link

nx-cloud bot commented Mar 15, 2024

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 6429495. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution


🟥 Failed Commands
nx affected --targets=test:format,test:sherif,test:knip,test:lib,test:types,build --parallel=3
✅ Successfully ran 1 target

Sent with 💌 from NxCloud.

@KevinVandy
Copy link
Member

invertSorting as a column option already exists. https://tanstack.com/table/latest/docs/guide/sorting#sorting-direction

sortUndefined as a column option already exists. https://tanstack.com/table/latest/docs/guide/sorting#sort-undefined-or-nullish-values

I do not see any of these changes as necessary.

@KevinVandy KevinVandy closed this Mar 15, 2024
@tychenjiajun
Copy link
Contributor Author

What about #2371 (comment) ? I still can't force null or empty values to bottom when sorting using sortUndefined and/or invertSorting, see Edit compassionate-matan-ltcq34

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants