Add support for Svelte 4 #4996
Merged
Add support for Svelte 4 #4996
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
+1 please update |
1 similar comment
|
+1 please update |
|
Hi, can any maintainer merge this change ? Its been sitting for 2 weeks 🙏 cc @tannerlinsley |
|
Hey @tannerlinsley could you please look at the PR? |
|
Done :) |
|
I came across this when following one of the examples from the docs (svelte basic), is it related to the version bump? Seems to work just fine, but my TS is yelling at me:
Previously I wasn't using |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Svelte 4 was announced back in June 2023
https://svelte.dev/blog/svelte-4
But Tanstack table doesn't allow version 4.x.x which is preventing all of us Svelte table users to use Svelte 4 which has been out for a month now. Svelte 4 doesn't have any breaking changes (very minor ones related to custom elements), so I don't expect anything to break for Tanstack, and it should unblock people from using Svelte 4.
There is no bug for this, but there is a discussion thread
#4944